You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2023/11/01 12:50:06 UTC
[PR] Pipe: Changed the sink loopback detection logic to support hostName and IPv6 specification. [iotdb]
Caideyipi opened a new pull request, #11455:
URL: https://github.com/apache/iotdb/pull/11455
## Description
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IOTDB-6220] Pipe: Changed the sink loopback detection logic to support hostName and IPv6 specification. [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #11455:
URL: https://github.com/apache/iotdb/pull/11455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IOTDB-6220] Pipe: Changed the sink loopback detection logic to support hostName and IPv6 specification. [iotdb]
Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula commented on code in PR #11455:
URL: https://github.com/apache/iotdb/pull/11455#discussion_r1379561752
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/NodeUrlUtils.java:
##########
@@ -188,10 +193,62 @@ public static List<TConfigNodeLocation> parseTConfigNodeUrls(String configNodeUr
return parseTConfigNodeUrls(Arrays.asList(configNodeUrls.split(";")));
}
- public static boolean isLocalAddress(String ip) {
- if (ip == null) {
+ /**
+ * Detect whether the given addresses or host names(may contain both) point to the node itself.
+ *
+ * @param addressesOrHostNames List of the addresses or host name to check
+ * @return true if one of the given strings point to the node itself
+ * @throws UnknownHostException Throw when unable to parse the given addresses or host names
+ */
+ public static boolean containsLocalAddress(List<String> addressesOrHostNames)
+ throws UnknownHostException {
+ if (addressesOrHostNames == null) {
return false;
}
- return ip.equals("0.0.0.0") || ip.equals("127.0.0.1") || ip.equals("localhost");
+
+ Set<String> selfAddresses = getAllLocalAddresses();
+
+ for (String addressOrHostName : addressesOrHostNames) {
+ if (addressOrHostName == null) {
+ continue;
+ }
+ // Unify address or hostName, converting them to addresses
+ HashSet<String> translatedAddresses =
+ Arrays.stream(InetAddress.getAllByName(addressOrHostName))
+ .map(InetAddress::getHostAddress)
+ .collect(Collectors.toCollection(HashSet::new));
+ translatedAddresses.retainAll(selfAddresses);
+
+ if (!translatedAddresses.isEmpty()) {
+ return true;
+ }
+ }
+
+ return false;
+ }
+
+ /**
+ * Return all the internal, external, IPv4, IPv6 and loopback addresses(without hostname) of the
+ * node
+ *
+ * @return the local addresses set
+ * @throws UnknownHostException Throw when unable to self addresses or host names (Normally not
+ * thrown)
+ */
+ public static Set<String> getAllLocalAddresses() throws UnknownHostException {
+ // Check internal and external, IPv4 and IPv6 network addresses
+ Set<String> selfAddresses =
+ Arrays.stream(InetAddress.getAllByName(InetAddress.getLocalHost().getHostName()))
+ .map(InetAddress::getHostAddress)
+ .collect(Collectors.toCollection(HashSet::new));
+ // Check IPv4 and IPv6 loopback addresses 127.0.0.1 and 0.0.0.0.0.0.0.1
+ selfAddresses.addAll(
+ Arrays.stream(InetAddress.getAllByName("localhost"))
+ .map(InetAddress::getHostAddress)
+ .collect(Collectors.toCollection(HashSet::new)));
+ // Check general address 0.0.0.0
+ selfAddresses.add("0.0.0.0");
Review Comment:
Don't use magic string, using private static constant instead.
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/NodeUrlUtils.java:
##########
@@ -188,10 +193,62 @@ public static List<TConfigNodeLocation> parseTConfigNodeUrls(String configNodeUr
return parseTConfigNodeUrls(Arrays.asList(configNodeUrls.split(";")));
}
- public static boolean isLocalAddress(String ip) {
- if (ip == null) {
+ /**
+ * Detect whether the given addresses or host names(may contain both) point to the node itself.
+ *
+ * @param addressesOrHostNames List of the addresses or host name to check
+ * @return true if one of the given strings point to the node itself
+ * @throws UnknownHostException Throw when unable to parse the given addresses or host names
+ */
+ public static boolean containsLocalAddress(List<String> addressesOrHostNames)
+ throws UnknownHostException {
+ if (addressesOrHostNames == null) {
return false;
}
- return ip.equals("0.0.0.0") || ip.equals("127.0.0.1") || ip.equals("localhost");
+
+ Set<String> selfAddresses = getAllLocalAddresses();
+
+ for (String addressOrHostName : addressesOrHostNames) {
+ if (addressOrHostName == null) {
+ continue;
+ }
+ // Unify address or hostName, converting them to addresses
+ HashSet<String> translatedAddresses =
+ Arrays.stream(InetAddress.getAllByName(addressOrHostName))
+ .map(InetAddress::getHostAddress)
+ .collect(Collectors.toCollection(HashSet::new));
+ translatedAddresses.retainAll(selfAddresses);
+
+ if (!translatedAddresses.isEmpty()) {
+ return true;
+ }
+ }
+
+ return false;
+ }
+
+ /**
+ * Return all the internal, external, IPv4, IPv6 and loopback addresses(without hostname) of the
+ * node
+ *
+ * @return the local addresses set
+ * @throws UnknownHostException Throw when unable to self addresses or host names (Normally not
+ * thrown)
+ */
+ public static Set<String> getAllLocalAddresses() throws UnknownHostException {
+ // Check internal and external, IPv4 and IPv6 network addresses
+ Set<String> selfAddresses =
+ Arrays.stream(InetAddress.getAllByName(InetAddress.getLocalHost().getHostName()))
+ .map(InetAddress::getHostAddress)
+ .collect(Collectors.toCollection(HashSet::new));
+ // Check IPv4 and IPv6 loopback addresses 127.0.0.1 and 0.0.0.0.0.0.0.1
+ selfAddresses.addAll(
+ Arrays.stream(InetAddress.getAllByName("localhost"))
Review Comment:
Don't use magic string, using private static constant instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org