svn commit: r1824989 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java

[ti...@apache.org]

Author: tilman
Date: Wed Feb 21 17:07:17 2018
New Revision: 1824989

URL: http://svn.apache.org/viewvc?rev=1824989&view=rev
Log:
PDFBOX-4071: make methods final that shouldn't be changed; make methods protected that shouldn't be accessed outside of class hierarchy

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java?rev=1824989&r1=1824988&r2=1824989&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java Wed Feb 21 17:07:17 2018
@@ -80,7 +80,7 @@ public abstract class PDAction implement
      *
      * @return The Type of PDF object.
      */
-    public String getType()
+    public final String getType()
     {
        return action.getNameAsString( COSName.TYPE );
     }
@@ -91,7 +91,7 @@ public abstract class PDAction implement
      *
      * @param type The new Type for the PDF object.
      */
-    public final void setType( String type )
+    protected final void setType(String type)
     {
        action.setName(COSName.TYPE, type );
     }
@@ -101,7 +101,7 @@ public abstract class PDAction implement
      *
      * @return The S entry of actions dictionary.
      */
-    public String getSubType()
+    public final String getSubType()
     {
         return action.getNameAsString(COSName.S);
     }
@@ -111,7 +111,7 @@ public abstract class PDAction implement
      *
      * @param s The new type of action.
      */
-    public void setSubType( String s )
+    protected final void setSubType(String s)
     {
         action.setName(COSName.S, s);
     }