You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/01 17:32:16 UTC

[GitHub] [pulsar] adrian-tarau opened a new issue, #17412: Unusual jar naming strategy

adrian-tarau opened a new issue, #17412:
URL: https://github.com/apache/pulsar/issues/17412

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Motivation
   
   The naming of the Pulsar jars is a bit unusual. If the project provides shaded JARs, they are named _*-shaded.jar_, and the original JAR is left as is. Most of the time, projects will include the non-shaded jar since it is not desired to duplicate another 20MB of dependencies. There are exceptions when there are version conflicts, and that's when you include the shared jar.
   
   ### Solution
   
   Add a classifier (shaded) and leave the original file name as is.
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on issue #17412: Unusual jar naming strategy

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #17412:
URL: https://github.com/apache/pulsar/issues/17412#issuecomment-1292873713

   The issue had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun closed issue #17412: Unusual jar naming strategy

Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #17412: Unusual jar naming strategy
URL: https://github.com/apache/pulsar/issues/17412


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #17412: Unusual jar naming strategy

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #17412:
URL: https://github.com/apache/pulsar/issues/17412#issuecomment-1234618594

   Is it a big deal about the name? Every project can has its own preference and if only it doesn't become a trouble for some integrations, it looks neutral to me to use `pulsar-client` as the shaded version and `pulsar-client-original` as the slim version.
   
   If we just change `pulsar-client` to the slim version, it will shock users who already use it as a shaded version. This is a user-facing interface change, but I don't see some reasonable advantages to doing so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #17412: Unusual jar naming strategy

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #17412:
URL: https://github.com/apache/pulsar/issues/17412#issuecomment-1309833353

   Closed as won't do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on issue #17412: Unusual jar naming strategy

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on issue #17412:
URL: https://github.com/apache/pulsar/issues/17412#issuecomment-1258812794

   I agree it's unusual. But that's a kind of breaking change. I don't think we have enough motivation to change the name.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] adrian-tarau commented on issue #17412: Unusual jar naming strategy

Posted by GitBox <gi...@apache.org>.
adrian-tarau commented on issue #17412:
URL: https://github.com/apache/pulsar/issues/17412#issuecomment-1258808372

   I would not say it is a big deal ... it's just unusual. Honestly, I used hundreds of libraries, and none of them have this file name policy in reverse. The shaded JAR has a different name, and the original JAR is based on the artifact identifier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org