[GitHub] [kafka] jolshan commented on a change in pull request #11784: KAFKA-13228; Ensure ApiVersionRequest is properly handled KRaft co-resident mode

[GitBox <gi...@apache.org>]

jolshan commented on a change in pull request #11784:
URL: https://github.com/apache/kafka/pull/11784#discussion_r812174096



##########
File path: core/src/test/java/kafka/testkit/KafkaClusterTestKit.java
##########
@@ -149,15 +149,17 @@ public KafkaClusterTestKit build() throws Exception {
                     ThreadUtils.createThreadFactory("KafkaClusterTestKit%d", false));
                 for (ControllerNode node : nodes.controllerNodes().values()) {
                     Map<String, String> props = new HashMap<>(configProps);
-                    props.put(KafkaConfig$.MODULE$.ProcessRolesProp(), "controller");
+                    props.put(KafkaConfig$.MODULE$.ProcessRolesProp(), nodes.isCoResident() ? "controller,broker" : "controller");
                     props.put(KafkaConfig$.MODULE$.NodeIdProp(),
                         Integer.toString(node.id()));
                     props.put(KafkaConfig$.MODULE$.MetadataLogDirProp(),
                         node.metadataDirectory());
                     props.put(KafkaConfig$.MODULE$.ListenerSecurityProtocolMapProp(),
-                        "CONTROLLER:PLAINTEXT");
+                        "EXTERNAL:PLAINTEXT,CONTROLLER:PLAINTEXT");
                     props.put(KafkaConfig$.MODULE$.ListenersProp(),
-                        "CONTROLLER://localhost:0");
+                        nodes.isCoResident() ? "EXTERNAL://localhost:0,CONTROLLER://localhost:0": "CONTROLLER://localhost:0");

Review comment:
       Looks like there are a few checkstyle issues in this file 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org