You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by hamnis <gi...@git.apache.org> on 2014/05/27 08:30:39 UTC
[GitHub] incubator-storm pull request: STORM-325: Change scope to provided
GitHub user hamnis opened a pull request:
https://github.com/apache/incubator-storm/pull/126
STORM-325: Change scope to provided
o use 2.10 as default
o Scala library is pulled in as transitive dependency; no need to be explicit
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hamnis/incubator-storm storm-325
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit d71316827d7f7676c0e8b60938d10587355f510d
Author: Erlend Hamnaberg <er...@hamnaberg.net>
Date: 2014-05-27T06:28:18Z
STORM-325: Change scope to provided
o use 2.10 as default
o Scala library is pulled in as transitive dependency; no need to be explicit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-325: Change scope to provided
Posted by hamnis <gi...@git.apache.org>.
Github user hamnis closed the pull request at:
https://github.com/apache/incubator-storm/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-325: Change scope to provided
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/126#issuecomment-46215874
Could you please upmerge? Other then that it looks good I am +1. Sorry it took so long to get this reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-325: Change scope to provided
Posted by hamnis <gi...@git.apache.org>.
Github user hamnis commented on the pull request:
https://github.com/apache/incubator-storm/pull/126#issuecomment-46237564
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-325: Change scope to provided
Posted by hamnis <gi...@git.apache.org>.
Github user hamnis commented on the pull request:
https://github.com/apache/incubator-storm/pull/126#issuecomment-46286496
This has already been done in master except defaulting to 2.10. No need for this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---