You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Max Bowsher <ma...@ukf.net> on 2005/10/29 18:13:08 UTC
Re: svn commit: r17093 - trunk/build/generator
djames@tigris.org wrote:
> Author: djames
> Date: Sat Oct 29 11:39:08 2005
> New Revision: 17093
>
> Modified:
> trunk/build/generator/gen_make.py
>
> Log:
> * build/generator/gen_make.py
> (Generator.write): Avoid usage of $< in SWIG header wrapper generator
> rules, so that our Makefile will be compatible with BSD make.
>
> Suggested by: Sigfred Haversen <bs...@mumak.com>
Doesn't that break VPATH non-releasemode builds? Since the headers are in
the source dir, but now header_wrappers.py is being handed a relative path
pointing to the build-dir?
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r17093 - trunk/build/generator
Posted by Max Bowsher <ma...@ukf.net>.
David James wrote:
> On 10/29/05, Max Bowsher <ma...@ukf.net> wrote:
>> djames@tigris.org wrote:
>>> Author: djames
>>> Date: Sat Oct 29 11:39:08 2005
>>> New Revision: 17093
>>>
>>> Modified:
>>> trunk/build/generator/gen_make.py
>>>
>>> Log:
>>> * build/generator/gen_make.py
>>> (Generator.write): Avoid usage of $< in SWIG header wrapper generator
>>> rules, so that our Makefile will be compatible with BSD make.
>>>
>>> Suggested by: Sigfred Haversen <bs...@mumak.com>
>> Doesn't that break VPATH non-releasemode builds? Since the headers are in
>> the source dir, but now header_wrappers.py is being handed a relative
>> path
>> pointing to the build-dir?
> Good catch, Max! I've fixed this problem in r17095 by explicitly
> listing the full path to the header file using $(abs_srcdir). I've
> also proposed r17095 for backport.
Thanks. It's such a shame there are all these different makes we have to
deal with.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r17093 - trunk/build/generator
Posted by David James <ja...@gmail.com>.
On 10/29/05, Max Bowsher <ma...@ukf.net> wrote:
> djames@tigris.org wrote:
> > Author: djames
> > Date: Sat Oct 29 11:39:08 2005
> > New Revision: 17093
> >
> > Modified:
> > trunk/build/generator/gen_make.py
> >
> > Log:
> > * build/generator/gen_make.py
> > (Generator.write): Avoid usage of $< in SWIG header wrapper generator
> > rules, so that our Makefile will be compatible with BSD make.
> >
> > Suggested by: Sigfred Haversen <bs...@mumak.com>
> Doesn't that break VPATH non-releasemode builds? Since the headers are in
> the source dir, but now header_wrappers.py is being handed a relative path
> pointing to the build-dir?
Good catch, Max! I've fixed this problem in r17095 by explicitly
listing the full path to the header file using $(abs_srcdir). I've
also proposed r17095 for backport.
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james