You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/06/02 15:40:13 UTC

[GitHub] [jackrabbit-oak] AngelaFabregues opened a new pull request, #586: OAK-9792 - The maximum number of search results per page is increased…

AngelaFabregues opened a new pull request, #586:
URL: https://github.com/apache/jackrabbit-oak/pull/586

   … to meet the AEM query max.
   
   This PR is ready and has been tested in local. However, we should wait or @fabriziofortino approval before merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] fabriziofortino commented on pull request #586: OAK-9792 - The maximum number of search results per page is increased…

Posted by GitBox <gi...@apache.org>.
fabriziofortino commented on PR #586:
URL: https://github.com/apache/jackrabbit-oak/pull/586#issuecomment-1146761625

   We should not increase this value. 10k results per page is already a quite large value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] fabriziofortino closed pull request #586: OAK-9792 - The maximum number of search results per page is increased…

Posted by GitBox <gi...@apache.org>.
fabriziofortino closed pull request #586: OAK-9792 - The maximum number of search results per page is increased…
URL: https://github.com/apache/jackrabbit-oak/pull/586


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] AngelaFabregues commented on a diff in pull request #586: OAK-9792 - The maximum number of search results per page is increased…

Posted by GitBox <gi...@apache.org>.
AngelaFabregues commented on code in PR #586:
URL: https://github.com/apache/jackrabbit-oak/pull/586#discussion_r888249168


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexDefinition.java:
##########
@@ -130,6 +136,7 @@ public ElasticIndexDefinition(NodeState root, NodeState defn, String indexPath,
         this.bulkRetriesBackoff = getOptionalValue(defn, BULK_RETRIES_BACKOFF, BULK_RETRIES_BACKOFF_DEFAULT);
         this.numberOfShards = getOptionalValue(defn, NUMBER_OF_SHARDS, NUMBER_OF_SHARDS_DEFAULT);
         this.numberOfReplicas = getOptionalValue(defn, NUMBER_OF_REPLICAS, NUMBER_OF_REPLICAS_DEFAULT);
+        this.maxResultWindow = getOptionalValue(defn, MAX_RESULT_WINDOW, AEM_QUERY_MAX);

Review Comment:
   Thanks. In parallel, I've also changed the approach to default to the Elasticsearch default value and to keep it configurable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #586: OAK-9792 - The maximum number of search results per page is increased…

Posted by GitBox <gi...@apache.org>.
reschke commented on code in PR #586:
URL: https://github.com/apache/jackrabbit-oak/pull/586#discussion_r888148931


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexDefinition.java:
##########
@@ -130,6 +136,7 @@ public ElasticIndexDefinition(NodeState root, NodeState defn, String indexPath,
         this.bulkRetriesBackoff = getOptionalValue(defn, BULK_RETRIES_BACKOFF, BULK_RETRIES_BACKOFF_DEFAULT);
         this.numberOfShards = getOptionalValue(defn, NUMBER_OF_SHARDS, NUMBER_OF_SHARDS_DEFAULT);
         this.numberOfReplicas = getOptionalValue(defn, NUMBER_OF_REPLICAS, NUMBER_OF_REPLICAS_DEFAULT);
+        this.maxResultWindow = getOptionalValue(defn, MAX_RESULT_WINDOW, AEM_QUERY_MAX);

Review Comment:
   please do not refer to product names inside the source code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org