Re: [PR] [SPARK-58167][BUILD][3.5] Add LICENSE files [spark]

["holdenk (via GitHub)" <gi...@apache.org>]

holdenk commented on code in PR #57317:
URL: https://github.com/apache/spark/pull/57317#discussion_r3610493199


##########
R/check-cran.sh:
##########
@@ -40,9 +40,12 @@ fi
 
 if [ -d "$SPARK_JARS_DIR" ]; then
   # Build a zip file containing the source package with vignettes
+  cp "$FWDIR/../LICENSE" "$FWDIR/pkg/LICENSE"
+  cp "$FWDIR/../NOTICE" "$FWDIR/pkg/NOTICE"

Review Comment:
   We need something like it, in Huaxin's 4.2 fix we do something a little different though. Let me update description so we don't trigger the chekc R failure even though we don't publish to cran anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org