You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/02/14 20:56:39 UTC
Review Request 69990: Added a regression test for MESOS-9555.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69990/
-----------------------------------------------------------
Review request for mesos and Meng Zhu.
Bugs: MESOS-9555
https://issues.apache.org/jira/browse/MESOS-9555
Repository: mesos
Description
-------
This test uses non-scalar reservations across two agents, which
is the same scenario that leads to the crash in MESOS-9555.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 1366cc51332484d7ff3b5e5b7ba767efb97172c0
Diff: https://reviews.apache.org/r/69990/diff/1/
Testing
-------
Ran in repetition
Thanks,
Benjamin Mahler
Re: Review Request 69990: Added a regression test for MESOS-9555.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69990/#review212846
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Feb. 14, 2019, 12:56 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69990/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2019, 12:56 p.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Bugs: MESOS-9555
> https://issues.apache.org/jira/browse/MESOS-9555
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test uses non-scalar reservations across two agents, which
> is the same scenario that leads to the crash in MESOS-9555.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 1366cc51332484d7ff3b5e5b7ba767efb97172c0
>
>
> Diff: https://reviews.apache.org/r/69990/diff/1/
>
>
> Testing
> -------
>
> Ran in repetition
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 69990: Added a regression test for MESOS-9555.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69990/#review212852
-----------------------------------------------------------
PASS: Mesos patch 69990 was successfully built and tested.
Reviews applied: `['69989', '69990']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2891/mesos-review-69990
- Mesos Reviewbot Windows
On Feb. 14, 2019, 8:56 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69990/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2019, 8:56 p.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Bugs: MESOS-9555
> https://issues.apache.org/jira/browse/MESOS-9555
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test uses non-scalar reservations across two agents, which
> is the same scenario that leads to the crash in MESOS-9555.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 1366cc51332484d7ff3b5e5b7ba767efb97172c0
>
>
> Diff: https://reviews.apache.org/r/69990/diff/1/
>
>
> Testing
> -------
>
> Ran in repetition
>
>
> Thanks,
>
> Benjamin Mahler
>
>