You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2010/01/04 12:53:55 UTC
[jira] Created: (LUCENE-2190) CustomScoreQuery (function query) is
broken (due to per-segment searching)
CustomScoreQuery (function query) is broken (due to per-segment searching)
--------------------------------------------------------------------------
Key: LUCENE-2190
URL: https://issues.apache.org/jira/browse/LUCENE-2190
Project: Lucene - Java
Issue Type: Bug
Components: Search
Affects Versions: 3.0, 2.9.1, 2.9, 3.0.1, 3.1
Reporter: Michael McCandless
Assignee: Michael McCandless
Fix For: 2.9.2, 3.0.1, 3.1
Spinoff from here:
http://lucene.markmail.org/message/psw2m3adzibaixbq
With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2190) CustomScoreQuery (function query)
is broken (due to per-segment searching)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836410#action_12836410 ]
Michael McCandless commented on LUCENE-2190:
--------------------------------------------
OK new patches look good Uwe! Thanks for fixing this :)
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190-2-branch30.patch, LUCENE-2190-2-trunk.patch, LUCENE-2190-2.patch, LUCENE-2190-2.patch, LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2190) CustomScoreQuery (function query) is
broken (due to per-segment searching)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-2190:
---------------------------------------
Attachment: LUCENE-2190.patch
Patch attached, adding setNextReader to CustomScoreQuery, and a test case. Also fixed a couple latent test bugs, when run on indexes with more than one segment.
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2190) CustomScoreQuery (function query)
is broken (due to per-segment searching)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796343#action_12796343 ]
Michael McCandless commented on LUCENE-2190:
--------------------------------------------
Patch applies to 2.9.x.
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2190) CustomScoreQuery (function query) is
broken (due to per-segment searching)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2190:
----------------------------------
Attachment: LUCENE-2190-2-branch29.patch
Here the patch for 2.9
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190-2-branch29.patch, LUCENE-2190-2-branch30.patch, LUCENE-2190-2-branch30.patch, LUCENE-2190-2-trunk.patch, LUCENE-2190-2-trunk.patch, LUCENE-2190-2.patch, LUCENE-2190-2.patch, LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2190) CustomScoreQuery (function query) is
broken (due to per-segment searching)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2190:
----------------------------------
Attachment: LUCENE-2190-2-branch30.patch
LUCENE-2190-2-trunk.patch
Here the patches for trunk (without deprecations) and 3.0 brach. 2.9 will be merged later. Merging from trunk -> 3.0 is not possible as TestCase heavily rewritten.
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190-2-branch30.patch, LUCENE-2190-2-trunk.patch, LUCENE-2190-2.patch, LUCENE-2190-2.patch, LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2190) CustomScoreQuery (function query)
is broken (due to per-segment searching)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836164#action_12836164 ]
Michael McCandless commented on LUCENE-2190:
--------------------------------------------
bq. Adding setNextReader to CustomScoreQuery makes the Query itsself stateful. This breaks when using together with e.g. ParallelMultiSearcher.
Ugh, you're right. Passing the current IR to customScore method isn't great because then you have to a check per call (per doc scored) to detect a switch to a new reader.
bq. but when we change to per-segment rewrite (as Mike plans)
I'm not quite "planning" that ;) I was mulling it... because it's somewhat inefficient now that an MTQ uses the multi terms enum instead of doing it per segment. But: this is only done for the BQ rewrite, which is only done when the number of terms is smallish (with AUTO default rewrite), so I think in practice the actual cost is low?
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2190) CustomScoreQuery (function query)
is broken (due to per-segment searching)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836396#action_12836396 ]
Michael McCandless commented on LUCENE-2190:
--------------------------------------------
Patch looks good!
Only thing is I think we should revert this:
{code}
@@ -382,7 +387,7 @@
@Override
public boolean scoresDocsOutOfOrder() {
- return false;
+ return subQueryWeight.scoresDocsOutOfOrder();
}
{code}
We need to return false from here because CSQ always scores in order (it asks the sub scorers for in-order scorers).
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190-2.patch, LUCENE-2190-2.patch, LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2190) CustomScoreQuery (function query) is
broken (due to per-segment searching)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2190:
----------------------------------
Attachment: LUCENE-2190-2.patch
Here a better solution. It now works like Filter's getDocIdSet: For customizing scores, you have to override the similar protected method getCustomScoreProvider(IndexReader) and return a subclass of CustomScoreProvider. The default delegates to the backwards layer.
The semantics is now identical to filters: Each IndexReader of a segment gets its own calculator like its own DocIdSet in filters.
Also fixes the following problems:
- rewrite() was incorrectly implemented (now works like BooleanQuery.rewrite())
- equals/hashCode ignored strict
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190-2.patch, LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2190) CustomScoreQuery (function query) is
broken (due to per-segment searching)
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-2190.
----------------------------------------
Resolution: Fixed
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2190) CustomScoreQuery (function query) is
broken (due to per-segment searching)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-2190.
-----------------------------------
Resolution: Fixed
Assignee: Uwe Schindler (was: Michael McCandless)
Lucene Fields: [New, Patch Available] (was: [New])
Committed 3.0 branch revision: 912383, 912389
Committed trunk revision: 912386
Committed 2.9 branch revision: 912390
Thanks Mike for the help!
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190-2-branch29.patch, LUCENE-2190-2-branch30.patch, LUCENE-2190-2-branch30.patch, LUCENE-2190-2-trunk.patch, LUCENE-2190-2-trunk.patch, LUCENE-2190-2.patch, LUCENE-2190-2.patch, LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Reopened: (LUCENE-2190) CustomScoreQuery (function query) is
broken (due to per-segment searching)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler reopened LUCENE-2190:
-----------------------------------
The fix is invalid:
Adding setNextReader to CustomScoreQuery makes the Query itsself stateful. This breaks when using together with e.g. ParallelMultiSearcher.
As the package is experimental, I see no problem in changing the method signature of customScore to pass in the affected IndexReader (CustomScorer can do this)
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2190) CustomScoreQuery (function query) is
broken (due to per-segment searching)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2190:
----------------------------------
Attachment: LUCENE-2190-2.patch
Updated patch (forgot to add an IOException to getCustomScoreProvider and fixed test).
Will backport after committing to 3.0 and 2.9 (argh).
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190-2.patch, LUCENE-2190-2.patch, LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2190) CustomScoreQuery (function query)
is broken (due to per-segment searching)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835837#action_12835837 ]
Uwe Schindler commented on LUCENE-2190:
---------------------------------------
We can preserve backwards compatibility is the default impl with the new reader only passes to the deprecated old customScore function.
I will provide a patch tomorrow.
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2190) CustomScoreQuery (function query)
is broken (due to per-segment searching)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835903#action_12835903 ]
Uwe Schindler commented on LUCENE-2190:
---------------------------------------
During refactoring I found out:
CustomScoreQuery is more broken: the rewrite() method is wrong, for now its not really a problem but when we change to per-segment rewrite (as Mike plans) its broken. Its even broken if you rewrite against one IndexReader and want to reuse the query later on another IndexReader. It rewrites all its subqueries and returns itsself, which is wrong: if one of the subqueries was rewritten it must return a new clone instance (like BooleanQuery). Also hashCode and equals ignore strict.
Will provide patch later. Now everything seems to work correct.
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2190) CustomScoreQuery (function query) is
broken (due to per-segment searching)
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2190:
----------------------------------
Attachment: LUCENE-2190-2-branch30.patch
LUCENE-2190-2-trunk.patch
Updated patches without javadocs-warnings / fixed javadocs. In trunk the backwards branch needs to be patched, too (merge from 3.0 branch).
> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
> Key: LUCENE-2190
> URL: https://issues.apache.org/jira/browse/LUCENE-2190
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2190-2-branch30.patch, LUCENE-2190-2-branch30.patch, LUCENE-2190-2-trunk.patch, LUCENE-2190-2-trunk.patch, LUCENE-2190-2.patch, LUCENE-2190-2.patch, LUCENE-2190.patch
>
>
> Spinoff from here:
> http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore, because the per-doc custom scoring method (customScore) receives a per-segment docID, yet there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched to. I think if we copy Collector.setNextReader, that would be sufficient. It would by default do nothing in CustomScoreQuery, but a subclass could override.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org