You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/08/16 09:50:12 UTC
[GitHub] [hive] zhangbutao opened a new pull request, #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
zhangbutao opened a new pull request, #3523:
URL: https://github.com/apache/hive/pull/3523
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Sse a timeout version of waitForAllInputsReady to avoid tez task stuck.
Please refer to https://issues.apache.org/jira/browse/HIVE-26459 for details.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
NO
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3523:
URL: https://github.com/apache/hive/pull/3523#issuecomment-1280110619
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on PR #3523:
URL: https://github.com/apache/hive/pull/3523#issuecomment-1288944362
> Waiting till all inputs are ready is intensional and having this to timeout based approach could destabilize and cause corner case issues.
@rbalamohan I agree. That's why the timeout configuration is turned off (-1ms) by default. But maybe we can add this configuration to give a workaround to fix some weird problem, like task stucking in [HIVE-26459](https://issues.apache.org/jira/browse/HIVE-26459).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] rbalamohan commented on pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
rbalamohan commented on PR #3523:
URL: https://github.com/apache/hive/pull/3523#issuecomment-1288895182
Waiting till all inputs are ready is intensional and having this to timeout based approach could destabilize and cause corner case issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on a diff in pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on code in PR #3523:
URL: https://github.com/apache/hive/pull/3523#discussion_r1003234219
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -5637,7 +5637,10 @@ public static enum ConfVars {
HIVE_ADDITIONAL_CONFIG_FILES("hive.additional.config.files", "",
"The names of additional config files, such as ldap-site.xml," +
- "tez-site.xml, etc in comma separated list.");
+ "tez-site.xml, etc in comma separated list."),
Review Comment:
Sure. done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
abstractdog commented on PR #3523:
URL: https://github.com/apache/hive/pull/3523#issuecomment-1323705650
I'm wondering how could weproceed with this, trying to understand TEZ-3302 in practice at the same time
@zhangbutao , @rbalamohan : can you explain a scenario when this timeout is dangerous? if so, depending on the risk, we should be able to decide whether to approve this change (disabled) or abandon at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3523:
URL: https://github.com/apache/hive/pull/3523#issuecomment-1289148669
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3523)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3523&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3523&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3523&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3523&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3523&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
URL: https://github.com/apache/hive/pull/3523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on a diff in pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
abstractdog commented on code in PR #3523:
URL: https://github.com/apache/hive/pull/3523#discussion_r1003072964
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -5637,7 +5637,10 @@ public static enum ConfVars {
HIVE_ADDITIONAL_CONFIG_FILES("hive.additional.config.files", "",
"The names of additional config files, such as ldap-site.xml," +
- "tez-site.xml, etc in comma separated list.");
+ "tez-site.xml, etc in comma separated list."),
Review Comment:
can you add this a bit closer to another hive.tez.* options instead of the end of list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3523:
URL: https://github.com/apache/hive/pull/3523#issuecomment-1288755123
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3523)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3523&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3523&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3523&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3523&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3523&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on PR #3523:
URL: https://github.com/apache/hive/pull/3523#issuecomment-1323938798
> I'm wondering how could weproceed with this, trying to understand TEZ-3302 in practice at the same time @zhangbutao , @rbalamohan : can you explain a scenario when this timeout is dangerous? if so, depending on the risk, we should be able to decide whether to approve this change (disabled) or abandon at all
>
> maybe it sounds weird, but I'm fine with an expert-level setting that can even lead to problems when used incorrectly (that's what we have everywhere in HiveConf :) )
>
> I feel that if we can agree on this, that can let us proceed with [TEZ-4445](https://issues.apache.org/jira/browse/TEZ-4445) too
@abstractdog Both this PR and https://issues.apache.org/jira/browse/TEZ-4445 were weird problems occasionally occuring in our busy cluster. I have no good luck to find these root causes, and just gave a workroud which adding timeout configuration.
To be honest, i have no idea which specific danger could be introduced by this change so i disabled this by default. But as you said and i also definitily agreed, we can define it expert-level setting and let user choose to enable or disable it.
I'd like to hear your opinion too. @rbalamohan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3523: HIVE-26459: ReduceRecordProcessor: move to using a timeout version of waitForAllInputsReady(TEZ-3302)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3523:
URL: https://github.com/apache/hive/pull/3523#issuecomment-1216470673
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3523)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=BUG) [103 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3523&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3523&resolved=false&types=SECURITY_HOTSPOT) [33 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3523&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=CODE_SMELL) [1767 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3523&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3523&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3523&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org