You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/09 12:58:52 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
ravening opened a new pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776
### Description
Display the traffic data in networks and vm api response
```
(local) mgt01 > list virtualmachines filter=receivedbytes,sentbytes,
{
"count": 2,
"virtualmachine": [
{
"receivedbytes": 187686,
"sentbytes": 99809
},
{
"receivedbytes": 189086,
"sentbytes": 90855
}
]
}
```
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-806348857
@ravening Can you fix the conflicts? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-895328995
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-896487200
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-895329470
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-899194784
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-866888398
Hi @ravening there is still a conflict with this PR can you please resolve it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-889691098
<b>Trillian test result (tid-1418)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59398 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4776-t1418-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 87 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3607.33 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3604.35 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 39.65 | test_kubernetes_clusters.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 401.94 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-889069481
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-889029042
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-895356770
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-889121535
<b>Trillian Build Failed (tid-1409)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-899178613
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-899193755
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-889069730
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-891283167
Hi @ravening can you please address the open comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-895357271
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-896486791
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-895251462
> Hi @ravening can you please address the open comments?
@nvazquez done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#discussion_r678905792
##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -394,6 +397,8 @@
private VMSnapshotDao vmSnapshotDao;
@Inject
private BackupOfferingDao backupOfferingDao;
+ @Inject
+ private UserStatisticsDao _userStatsDao;
Review comment:
@GabrielBrascher changed the code. please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-896432904
<b>Trillian test result (tid-1560)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 117605 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4776-t1560-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 59 look OK, 30 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
test_DeleteDomain | `Error` | 3.98 | test_accounts.py
test_forceDeleteDomain | `Failure` | 3.97 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.33 | test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
ContextSuite context=TestAsyncJob>:setup | `Error` | 0.00 | test_async_job.py
test_01_create_iso_with_checksum_sha1 | `Error` | 67.42 | test_iso.py
test_02_1_create_iso_with_checksum_sha256_negative | `Error` | 66.80 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 67.09 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 67.09 | test_iso.py
test_03_1_create_iso_with_checksum_md5_negative | `Error` | 70.16 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 67.91 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 67.96 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 67.96 | test_iso.py
test_01_create_iso | `Failure` | 1588.17 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3104.09 | test_iso.py
ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1568.62 | test_domain_service_offerings.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
test_list_clusters_metrics | `Error` | 1534.75 | test_metrics_api.py
test_list_vms_metrics | `Error` | 0.17 | test_metrics_api.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 60.56 | test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_nic_secondaryip_add_remove | `Error` | 1553.75 | test_multipleips_per_nic.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1570.04 | test_projects.py
ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
test_02_create_template_with_checksum_sha1 | `Error` | 67.41 | test_templates.py
test_04_extract_template | `Failure` | 128.33 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
test_10_attachAndDetach_iso | `Failure` | 1514.42 | test_vm_life_cycle.py
test_06_download_detached_volume | `Error` | 318.07 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 806.21 | test_hostha_kvm.py
test_hostha_kvm_host_degraded | `Error` | 8.21 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#discussion_r600787824
##########
File path: server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java
##########
@@ -78,6 +81,8 @@
private UserDao _userDao;
@Inject
private NicExtraDhcpOptionDao _nicExtraDhcpOptionDao;
+ @Inject
+ UserStatisticsDao _userStatsDao;
Review comment:
I don't want to sound repetitive and I would not block a PR due to `_`, in any circumstance. But I would really appreciate it if you could remove `_` from any added variable :slightly_smiling_face:
##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -394,6 +397,8 @@
private VMSnapshotDao vmSnapshotDao;
@Inject
private BackupOfferingDao backupOfferingDao;
+ @Inject
+ private UserStatisticsDao _userStatsDao;
Review comment:
@ravening can you please remove the underscore `_` at the beginning of the variable name?
Many variables on the codebase have `_` at the beginning but it is not aligned with the [Java variable naming convention](https://docs.oracle.com/javase/tutorial/java/nutsandbolts/variables.html).
According to [Java variable naming convention](https://docs.oracle.com/javase/tutorial/java/nutsandbolts/variables.html):
> A similar convention exists for the underscore character; while it's technically legal to begin your variable's name with "_", this practice is discouraged. White space is not permitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-806156852
Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-806067992
Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-890101931
> Code LGTM.
> But to me seems like you are using the key 'final' where we don't need it.
>
> Did I understood something wrong?
>
> Do we need more manual test on this PR? since @nvazquez has already did some tests.
It is, in some circles, good practice to make sure a parameter is only changed consciously. A bit overdone indeed, i would agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-895350889
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-899178381
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-899194689
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-889121535
<b>Trillian Build Failed (tid-1409)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on a change in pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#discussion_r680002864
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
##########
@@ -911,4 +919,12 @@ public String getOsDisplayName() {
public String getPoolType() { return poolType; }
public void setPoolType(String poolType) { this.poolType = poolType; }
+
+ public void setBytesReceived(final Long bytesReceived) {
Review comment:
I don't fully understand why the key 'final' is being used here. You don't need to use it here.
am I wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-899635770
<b>Trillian test result (tid-1649)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42125 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4776-t1649-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_list_snapshots_with_removed_data_store | `Error` | 50.28 | test_snapshots.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 593.61 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 570.58 | test_vpc_redundant.py
test_01_vpc_site2site_vpn_multiple_options | `Failure` | 677.02 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on a change in pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#discussion_r680003213
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
##########
@@ -911,4 +919,12 @@ public String getOsDisplayName() {
public String getPoolType() { return poolType; }
public void setPoolType(String poolType) { this.poolType = poolType; }
+
+ public void setBytesReceived(final Long bytesReceived) {
+ this.bytesReceived = bytesReceived;
+ }
+
+ public void setBytesSent(final Long bytesSent) {
Review comment:
and here.
##########
File path: server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java
##########
@@ -365,9 +370,26 @@ public UserVmResponse newUserVmResponse(ResponseView view, String objectName, Us
userVmResponse.setDynamicallyScalable(userVm.isDynamicallyScalable());
}
+ addVmRxTxDataToResponse(userVm, userVmResponse);
+
return userVmResponse;
}
+ private void addVmRxTxDataToResponse(final UserVmJoinVO userVm, final UserVmResponse userVmResponse) {
Review comment:
and again. here.
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -495,4 +503,12 @@ public Date getCreated() {
public void setCreated(Date created) {
this.created = created;
}
+
+ public void setBytesReceived(final Long bytesReceived) {
Review comment:
I don't fully understand why the key 'final' is being used here. You don't need to use it here.
am I wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4776: Add sent and received bytes to listNetworks and listVirtualMachines.
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-805611827
> clgtm needs testing, can you add info about the use-case to the description or refer an issue (even though it is trivial, it might hekp tracking if someone asks about this)
@DaanHoogland added more details in description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org