You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org> on 2009/05/11 10:35:46 UTC
[jira] Created: (SYNAPSE-546) Use EndpointReference class helper
methods instead of checking for each urls.
Use EndpointReference class helper methods instead of checking for each urls.
-----------------------------------------------------------------------------
Key: SYNAPSE-546
URL: https://issues.apache.org/jira/browse/SYNAPSE-546
Project: Synapse
Issue Type: Improvement
Reporter: Amila Chinthaka Suriarachchi
Synapse checks the annonymous endpoint references for nhttp transport with following code.
(msgContext.getTo() != null) &&
!AddressingConstants.Submission.WSA_ANONYMOUS_URL.equals(
msgContext.getTo().getAddress()) &&
!AddressingConstants.Final.WSA_ANONYMOUS_URL.equals(
msgContext.getTo().getAddress()))
but it can simply write as
(msgContext.getTo() != null) && !msgContext.getTo().hasAnonymousAddress()) {
Note that hasAnonymousAddress method checks anonymousEquivalentURIs. RM 1.1 specification uses such
private annonymous URI and this change is needed to work synapse with Sandesh2 RM 1.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-546) Use EndpointReference class helper
methods instead of checking for each urls.
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708150#action_12708150 ]
Ruwan Linton commented on SYNAPSE-546:
--------------------------------------
It seems to be straight forward... thanks for the contribution.
I have applied the patch
> Use EndpointReference class helper methods instead of checking for each urls.
> -----------------------------------------------------------------------------
>
> Key: SYNAPSE-546
> URL: https://issues.apache.org/jira/browse/SYNAPSE-546
> Project: Synapse
> Issue Type: Improvement
> Reporter: Amila Chinthaka Suriarachchi
> Assignee: Ruwan Linton
> Fix For: 1.3
>
> Attachments: patch.txt
>
>
> Synapse checks the annonymous endpoint references for nhttp transport with following code.
> (msgContext.getTo() != null) &&
> !AddressingConstants.Submission.WSA_ANONYMOUS_URL.equals(
> msgContext.getTo().getAddress()) &&
> !AddressingConstants.Final.WSA_ANONYMOUS_URL.equals(
> msgContext.getTo().getAddress()))
> but it can simply write as
> (msgContext.getTo() != null) && !msgContext.getTo().hasAnonymousAddress()) {
> Note that hasAnonymousAddress method checks anonymousEquivalentURIs. RM 1.1 specification uses such
> private annonymous URI and this change is needed to work synapse with Sandesh2 RM 1.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Updated: (SYNAPSE-546) Use EndpointReference class helper
methods instead of checking for each urls.
Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amila Chinthaka Suriarachchi updated SYNAPSE-546:
-------------------------------------------------
Attachment: patch.txt
attached the patch with the trunk.
IMHO this should go to synapse 1.3 release as well.
> Use EndpointReference class helper methods instead of checking for each urls.
> -----------------------------------------------------------------------------
>
> Key: SYNAPSE-546
> URL: https://issues.apache.org/jira/browse/SYNAPSE-546
> Project: Synapse
> Issue Type: Improvement
> Reporter: Amila Chinthaka Suriarachchi
> Attachments: patch.txt
>
>
> Synapse checks the annonymous endpoint references for nhttp transport with following code.
> (msgContext.getTo() != null) &&
> !AddressingConstants.Submission.WSA_ANONYMOUS_URL.equals(
> msgContext.getTo().getAddress()) &&
> !AddressingConstants.Final.WSA_ANONYMOUS_URL.equals(
> msgContext.getTo().getAddress()))
> but it can simply write as
> (msgContext.getTo() != null) && !msgContext.getTo().hasAnonymousAddress()) {
> Note that hasAnonymousAddress method checks anonymousEquivalentURIs. RM 1.1 specification uses such
> private annonymous URI and this change is needed to work synapse with Sandesh2 RM 1.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Resolved: (SYNAPSE-546) Use EndpointReference class helper
methods instead of checking for each urls.
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruwan Linton resolved SYNAPSE-546.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.3
Applied the patch
> Use EndpointReference class helper methods instead of checking for each urls.
> -----------------------------------------------------------------------------
>
> Key: SYNAPSE-546
> URL: https://issues.apache.org/jira/browse/SYNAPSE-546
> Project: Synapse
> Issue Type: Improvement
> Reporter: Amila Chinthaka Suriarachchi
> Assignee: Ruwan Linton
> Fix For: 1.3
>
> Attachments: patch.txt
>
>
> Synapse checks the annonymous endpoint references for nhttp transport with following code.
> (msgContext.getTo() != null) &&
> !AddressingConstants.Submission.WSA_ANONYMOUS_URL.equals(
> msgContext.getTo().getAddress()) &&
> !AddressingConstants.Final.WSA_ANONYMOUS_URL.equals(
> msgContext.getTo().getAddress()))
> but it can simply write as
> (msgContext.getTo() != null) && !msgContext.getTo().hasAnonymousAddress()) {
> Note that hasAnonymousAddress method checks anonymousEquivalentURIs. RM 1.1 specification uses such
> private annonymous URI and this change is needed to work synapse with Sandesh2 RM 1.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Assigned: (SYNAPSE-546) Use EndpointReference class helper
methods instead of checking for each urls.
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruwan Linton reassigned SYNAPSE-546:
------------------------------------
Assignee: Ruwan Linton
> Use EndpointReference class helper methods instead of checking for each urls.
> -----------------------------------------------------------------------------
>
> Key: SYNAPSE-546
> URL: https://issues.apache.org/jira/browse/SYNAPSE-546
> Project: Synapse
> Issue Type: Improvement
> Reporter: Amila Chinthaka Suriarachchi
> Assignee: Ruwan Linton
> Attachments: patch.txt
>
>
> Synapse checks the annonymous endpoint references for nhttp transport with following code.
> (msgContext.getTo() != null) &&
> !AddressingConstants.Submission.WSA_ANONYMOUS_URL.equals(
> msgContext.getTo().getAddress()) &&
> !AddressingConstants.Final.WSA_ANONYMOUS_URL.equals(
> msgContext.getTo().getAddress()))
> but it can simply write as
> (msgContext.getTo() != null) && !msgContext.getTo().hasAnonymousAddress()) {
> Note that hasAnonymousAddress method checks anonymousEquivalentURIs. RM 1.1 specification uses such
> private annonymous URI and this change is needed to work synapse with Sandesh2 RM 1.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org