You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/03 14:04:09 UTC

[GitHub] [pulsar] Mefl opened a new pull request #7446: [Issue 7445][Pulsar client] Avoid NPE on null payload

Mefl opened a new pull request #7446:
URL: https://github.com/apache/pulsar/pull/7446


   Fixes #7445
   
   ### Motivation
   
   https://github.com/apache/pulsar/commit/d55bc00f34a2fa763a3756fa0adbb1366ae319bd introduced the capacity to have a null payload to msg, but the ConsumerStatsRecorderImpl wasn't adapted so an NPE occurs when the payload is null.
   
   ### Modifications
   
   ConsumerStatsRecorderImpl was modified to escape the case of null payload.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API:  no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no 
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie closed pull request #7446: [Issue 7445][Pulsar client] Avoid NPE on null payload

Posted by GitBox <gi...@apache.org>.
sijie closed pull request #7446:
URL: https://github.com/apache/pulsar/pull/7446


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #7446: [Issue 7445][Pulsar client] Avoid NPE on null payload

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7446:
URL: https://github.com/apache/pulsar/pull/7446#issuecomment-653970818


   @Mefl this was already fixed by #7408


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org