You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/01 04:05:00 UTC

[jira] [Commented] (ORC-221) RecordReaderImpl::evaluatePredicateMinMax should check whether predicate.getLiteralList() is empty

    [ https://issues.apache.org/jira/browse/ORC-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108350#comment-16108350 ] 

ASF GitHub Bot commented on ORC-221:
------------------------------------

GitHub user rajeshbalamohan opened a pull request:

    https://github.com/apache/orc/pull/145

    ORC-221: RecordReaderImpl::evaluatePredicateMinMax should check wheth…

    ORC-221: RecordReaderImpl::evaluatePredicateMinMax should check whether predicate.getLiteralList() is empty

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rajeshbalamohan/orc ORC-221

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #145
    
----
commit 292c1811361eb783a85d8c2e1c05f1a2aff384a1
Author: Rajesh Balamohan <rb...@apache.org>
Date:   2017-08-01T04:00:02Z

    ORC-221: RecordReaderImpl::evaluatePredicateMinMax should check whether predicate.getLiteralList() is empty

----


> RecordReaderImpl::evaluatePredicateMinMax should check whether predicate.getLiteralList() is empty
> --------------------------------------------------------------------------------------------------
>
>                 Key: ORC-221
>                 URL: https://issues.apache.org/jira/browse/ORC-221
>             Project: ORC
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Priority: Minor
>
> With HIVE-17209, it is possible to get empty list when invoking {{predicate.getLiteralList}}. When evaluating {{BETWEEN}} operator in {{RecordReaderImpl::evaluatePredicateMinMax}}, it is possible to get {{IndexOutOfBoundsException}}. 
> Though exception is caught and skips PPD in {{pickRowGroups}}, it would be good to avoid this exception being generated too many times by having boundary checks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)