[GitHub] [hbase] sunhelly commented on a diff in pull request #5252: HBASE-27881 The sleep time in checkQuota of replication WAL reader sh…

["sunhelly (via GitHub)" <gi...@apache.org>]

sunhelly commented on code in PR #5252:
URL: https://github.com/apache/hbase/pull/5252#discussion_r1204888906


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java:
##########
@@ -266,14 +267,16 @@ public Path getCurrentPath() {
     return logQueue.getQueue(walGroupId).peek();
   }
 
-  // returns false if we've already exceeded the global quota
-  private boolean checkBufferQuota() {
+  // sleeping when we've already exceeded the global quota
+  private void checkBufferQuota() {
     // try not to go over total quota
-    if (!this.getSourceManager().checkBufferQuota(this.source.getPeerId())) {
-      Threads.sleep(sleepForRetries);
-      return false;
+    while (

Review Comment:
   Yes. Let me change it back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org