You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/29 08:41:12 UTC
[PR] Consolidate database protocol exceptions [shardingsphere]
terrymanu opened a new pull request, #39634:
URL: https://github.com/apache/shardingsphere/pull/39634
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate database protocol exceptions [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39634:
URL: https://github.com/apache/shardingsphere/pull/39634#issuecomment-5461651455
### Result
**Review Result: Mergeable**
With compatibility excluded, the exception consolidation is complete and behaviorally consistent. No other blocking issues were found.
### Evidence
- The latest head remains `f8936003d16c3eb830e8a2edd52b8d49002b93d1`.
- All three dialect-specific exception classes are removed, and every repository production and test reference is migrated to `DatabaseProtocolException`.
- No subclasses or references to the removed exception classes remain.
- Exception message formatting and `SQLExceptionTransformEngine` behavior remain equivalent.
- `git diff --check` passed.
- Tests passed for exception-core, the Firebird/MySQL/PostgreSQL protocol modules, and the Firebird Proxy frontend module.
- The final convergence pass found no additional independent issues.
### Coverage
- All 47 GitHub-listed changed files were reviewed; the local triple-dot file list matched GitHub exactly.
- Coverage included shared exception ownership and removal, all three protocol migrations, the Firebird Proxy migration, test validity, dependency impact, and runtime exception mapping.
- This is a code-correctness result only; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Consolidate database protocol exceptions [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39634:
URL: https://github.com/apache/shardingsphere/pull/39634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org