You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/21 22:00:17 UTC

[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #15969: [WIP] Partitioning Gluon HybridBlocks

eric-haibin-lin commented on a change in pull request #15969: [WIP] Partitioning Gluon HybridBlocks
URL: https://github.com/apache/incubator-mxnet/pull/15969#discussion_r369266221
 
 

 ##########
 File path: python/mxnet/gluon/block.py
 ##########
 @@ -932,6 +932,9 @@ def _get_graph(self, *args):
 
     def _build_cache(self, *args):
         data, out = self._get_graph(*args)
+        if self._backend:
+            # To do: pass in all arguments
+            out = out.optimize_for(self._backend, **self.optargs)
 
 Review comment:
   Why not do it inside `self._get_graph`? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services