[GitHub] [airflow] uranusjr commented on a change in pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #22386:
URL: https://github.com/apache/airflow/pull/22386#discussion_r830732593



##########
File path: docs/apache-airflow/concepts/smart-sensors.rst
##########
@@ -85,6 +85,8 @@ It is transparent to the individual users. Existing DAGs don't need to be change
 enabling/disabling the smart sensor. Rotating centralized smart sensor tasks will not
 cause any user’s sensor task failure.
 
+*   Callback arguments(``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on sensor operator are not compatible with smart sensor. If any callback arguments is provided, that sensor task will not be executed on smart sensor.

Review comment:
       ```suggestion
   *   Using callback arguments (``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on a sensor task is not compatible with the smart sensor mode. If any callback arguments are provided, the sensor task will not be executed in smart sensor mode.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org