You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Vitalii Diravka (Jira)" <ji...@apache.org> on 2021/11/14 23:02:00 UTC

[jira] [Commented] (DRILL-1896) Unit tests failing due to string based comparison at JsonStringHashMap & JsonStringArrayList #equals methods

    [ https://issues.apache.org/jira/browse/DRILL-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443484#comment-17443484 ] 

Vitalii Diravka commented on DRILL-1896:
----------------------------------------

[~jnadeau] is right DRILL-1824 is mixed with this Jira. DRILL-1824 is resolved:
{code:java}
apache drill> select * from dfs.home.`/vector/complex/writer/schemaChange`;
+------+---------------+
|  a   |       b       |
+------+---------------+
| foo  | null          |
| bar  | null          |
| foo2 | {}            |
| bar2 | {"x":1,"y":2} |
+------+---------------+
4 rows selected (0.195 seconds) {code}
But this one is not resolved and causes _TestJsonReader#schemaChangeValidate_ to fail

> Unit tests failing due to string based comparison at JsonStringHashMap & JsonStringArrayList #equals methods
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-1896
>                 URL: https://issues.apache.org/jira/browse/DRILL-1896
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Hanifi Gunes
>            Assignee: Vitalii Diravka
>            Priority: Major
>             Fix For: 0.8.0
>
>         Attachments: DRILL-1896-v3.patch, DRILL-1896.patch, RILL-1896-v2.patch
>
>
> Unit test framework relies on JsonString*#equals methods to compare actual and expected results. We should properly implement these to prevent unit tests from failing.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)