You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/04 20:31:13 UTC
[GitHub] [ozone] bharatviswa504 opened a new pull request #1660: HDDS-4537. Remove refreshPipeline in listKeys.
bharatviswa504 opened a new pull request #1660:
URL: https://github.com/apache/ozone/pull/1660
## What changes were proposed in this pull request?
Remove refreshPipeline in listKeys implementation.
For client for list Keys, it needs basic info KeyName, replication type factor, etc., For more refer OzoneKey class.
As RpcClient is returning only info like KeyName, length, replication type, factor, modificationTime, creationTime. So we don't really need an extra param, as previously even though server sent pipelineInfo it is not used/returned to the client. So we don't need extra param, we can remove refresh pipeline in OM Server.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4537
## How was this patch tested?
Existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #1660: HDDS-4537. Remove refreshPipeline in listKeys.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #1660:
URL: https://github.com/apache/ozone/pull/1660#issuecomment-741131880
Thank You everyone for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #1660: HDDS-4537. Remove refreshPipeline in listKeys.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #1660:
URL: https://github.com/apache/ozone/pull/1660#issuecomment-740930509
> Tests are failing with:
>
> ```
> om_1 | java.lang.NullPointerException
> om_1 | at org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo.getProtobuf(OmKeyLocationInfo.java:174)
> om_1 | at org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo.getProtobuf(OmKeyLocationInfo.java:160)
> om_1 | at org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfoGroup.getProtobuf(OmKeyLocationInfoGroup.java:91)
> om_1 | at org.apache.hadoop.ozone.om.helpers.OmKeyInfo.getProtobuf(OmKeyInfo.java:399)
> om_1 | at org.apache.hadoop.ozone.om.helpers.OmKeyInfo.getProtobuf(OmKeyInfo.java:385)
> om_1 | at org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.listKeys(OzoneManagerRequestHandler.java:400)
> om_1 | at org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.handleReadRequest(OzoneManagerRequestHandler.java:156)
> ```
>
> I think the following additional change is needed:
>
> ```
> diff --git hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java
> index 35ab2753d..54484f6ec 100644
> --- hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java
> +++ hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java
> @@ -397,7 +397,7 @@ private ListKeysResponse listKeys(ListKeysRequest request)
> request.getPrefix(),
> request.getCount());
> for (OmKeyInfo key : keys) {
> - resp.addKeyInfo(key.getProtobuf());
> + resp.addKeyInfo(key.getProtobuf(true));
> }
>
> return resp.build();
> ```
Thank You @adoroszlai for the hint, looks like this is the issue. (Even failed UT's when I run see the same issue)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 merged pull request #1660: HDDS-4537. Remove refreshPipeline in listKeys.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #1660:
URL: https://github.com/apache/ozone/pull/1660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #1660: HDDS-4537. Remove refreshPipeline in listKeys.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #1660:
URL: https://github.com/apache/ozone/pull/1660#issuecomment-740931254
@adoroszlai I have updated the PR and will wait for the CI run to see how it goes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org