Re: [jira] [Commented] (TRINIDAD-2172) pseudo classes missing from CSSGenerationUtils

[Anand Nath <an...@oracle.com>]

Hello,

Can some one review and commit this fix?

Thanks
Anand

On 12/29/2011 12:22 PM, Anand V Nath (Commented) (JIRA) wrote:
>      [ https://issues.apache.org/jira/browse/TRINIDAD-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177027#comment-13177027 ]
>
> Anand V Nath commented on TRINIDAD-2172:
> ----------------------------------------
>
> The patch attached takes care of the CSS3 pseudo classes.
>
>      /** CSS 3 pseudo classes */
>      _BUILT_IN_PSEUDO_CLASSES.add(":nth-child");
>      _BUILT_IN_PSEUDO_CLASSES.add(":nth-last-child");
>      _BUILT_IN_PSEUDO_CLASSES.add(":nth-of-type");
>      _BUILT_IN_PSEUDO_CLASSES.add(":nth-last-of-type");
>      _BUILT_IN_PSEUDO_CLASSES.add(":last-child");
>      _BUILT_IN_PSEUDO_CLASSES.add(":first-of-type");
>      _BUILT_IN_PSEUDO_CLASSES.add(":last-of-type");
>      _BUILT_IN_PSEUDO_CLASSES.add(":only-child");
>      _BUILT_IN_PSEUDO_CLASSES.add(":only-of-type");
>      _BUILT_IN_PSEUDO_CLASSES.add(":root");
>      _BUILT_IN_PSEUDO_CLASSES.add(":target");
>      _BUILT_IN_PSEUDO_CLASSES.add(":enabled");
>      _BUILT_IN_PSEUDO_CLASSES.add(":checked");
>      _BUILT_IN_PSEUDO_CLASSES.add(":not");
>      _BUILT_IN_PSEUDO_CLASSES.add(":lang");
>      _BUILT_IN_PSEUDO_CLASSES.add(":indeterminate");
>
> There are four special case pseudo elements which are also handled.
>
> /** Special case CSS2 pseudo-elements used as pseudo-classes
>       * for compatibility reasons.
>       * Refer: http://www.w3.org/TR/selectors/#pseudo-elements */
>      _BUILT_IN_PSEUDO_CLASSES.add(":after");
>      _BUILT_IN_PSEUDO_CLASSES.add(":before");
>      _BUILT_IN_PSEUDO_CLASSES.add(":first-line");
>      _BUILT_IN_PSEUDO_CLASSES.add(":first-letter");
>
> For backward compatibility special treatment is given for following pseudo classes
>      /** CSS3 pseudo classes for backward compatibility*/
>      _BACKWARD_COMPATIBLE_CSS3_PSEUDO_CLASSES.add(":disabled");
>      _BACKWARD_COMPATIBLE_CSS3_PSEUDO_CLASSES.add(":empty");
>
>> pseudo classes missing from CSSGenerationUtils
>> ----------------------------------------------
>>
>>                  Key: TRINIDAD-2172
>>                  URL: https://issues.apache.org/jira/browse/TRINIDAD-2172
>>              Project: MyFaces Trinidad
>>           Issue Type: Improvement
>>           Components: Skinning
>>     Affects Versions: 2.0.0-core
>>             Reporter: Jeremy C. Hull
>>          Attachments: bug-13253267-3.patch
>>
>>
>> Only the following built-in pseudo classes are handled
>>      _BUILT_IN_PSEUDO_CLASSES.add(":first-child");
>>      _BUILT_IN_PSEUDO_CLASSES.add(":link");
>>      _BUILT_IN_PSEUDO_CLASSES.add(":visited");
>>      _BUILT_IN_PSEUDO_CLASSES.add(":hover");
>>      _BUILT_IN_PSEUDO_CLASSES.add(":active");
>>      _BUILT_IN_PSEUDO_CLASSES.add(":focus");
>> There are a few CSS2.1 and a bunch of CSS3 pseudo classes that should be handled.
>> first-letter, first-line, only-child, last-child, nth-child, nth-child-of-type, etc...
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>