[GitHub] [netbeans] peedeeboy commented on issue #1234: FIX: SASS integration is broken - removed old parameter "--cache-location"

[GitBox <gi...@apache.org>]

peedeeboy commented on issue #1234: FIX: SASS integration is broken - removed old parameter "--cache-location"
URL: https://github.com/apache/netbeans/pull/1234#issuecomment-499243651
 
 
   @maxcuttins Thank you so much for working on this, I've seen this brought up a couple of times so I'm sure quite a few people will be happy to see SASS support working again :)  Apologies I haven't got around to testing until now!
   
   I've tested on Windows with the dart-sass batch file, and with the .js implementation running through node.  Both worked ok including adding additional parameters via the Project properties.
   
   @matthiasblaesing Yes - this definitely makes things better and I think you are right to merge.   I was a bit apprehensive as I saw in the old bugzilla that these parameters had already been removed in the past, then re-added later (probably for the reasons I mention - there is an incomplete class specifically for libsass implementations). See here: https://netbeans.org/bugzilla/show_bug.cgi?id=271126
   
   There is still a bit of work to do in the long run, as the SassExecutable class was designed for Ruby SASS, some of the other methods such as checking version won't get the results they expect. 
   
   The only downside to this that I found in testing is that the Generate Sourcemaps flag in NB Options won't have any effect (due to the logic in the version check above not working with as expected with libsass implementations). 
   
   However, this can be worked around by adding the `--no-source-map` parameter in the Project Properties, so I think it is probably more important to get @maxcuttins fix in for NB11.1 and we can open a new Jira ticket for the tidy up work?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists