You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/11/07 11:15:48 UTC
[GitHub] [fineract] ruchiD opened a new pull request, #2732: FINERACT-1734-Negative-balance-event
ruchiD opened a new pull request, #2732:
URL: https://github.com/apache/fineract/pull/2732
## Description
Describe the changes made and why they were made.
1.New Event for Loan overpaid event
2.Business step for COB for checking loan account overpaid. This step checks if loan status is changed to overpaid on current business date and raises event.
3.Configurations for Event.
4.Added overpaidOnDate date for Loan entity to check date when loan got overpaid. When Loan account status changes to overpaid this date is set as current business date. When loan account overpaid status is changed due to change back refund and loan account overpaid status is zero this date gets reset.
5.Unit Tests.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics closed pull request #2732: FINERACT-1734-Negative-balance-event
Posted by GitBox <gi...@apache.org>.
galovics closed pull request #2732: FINERACT-1734-Negative-balance-event
URL: https://github.com/apache/fineract/pull/2732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2732: FINERACT-1734-Negative-balance-event
Posted by GitBox <gi...@apache.org>.
vidakovic commented on PR #2732:
URL: https://github.com/apache/fineract/pull/2732#issuecomment-1325564573
@ruchiD @galovics ... what's the status of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org