You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dg4prez <gi...@git.apache.org> on 2017/04/01 16:36:21 UTC
[GitHub] incubator-trafficcontrol pull request #423: move header rewrite to cdn scope...
GitHub user dg4prez opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/423
move header rewrite to cdn scope for cacheability
This moves the header rewrite files from server scope to cdn scope, making them cacheable. This should cut down significantly on the number of requests per server.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dg4prez/incubator-trafficcontrol hdr_rw_scope
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/423.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #423
----
commit 7e79d488dcd4b73ce76c05b487517a763d83c889
Author: Derek Gelinas <mr...@gmail.com>
Date: 2017-04-01T16:34:38Z
move header rewrite to cdn scope for cacheability
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #423: move header rewrite to cdn scope for ca...
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/423
@dg4prez - can you split this into 2 PR's? I can look at the API part but don't feel qualified to review ORT code as I'm not very familiar with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #423: move server scope files to cdn scope fo...
Posted by mtorluemke <gi...@git.apache.org>.
Github user mtorluemke commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/423
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #423: move header rewrite to cdn scope for ca...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/423
I would prefer to keep it together as one requires the other - perhaps we could get Mark to sign off on the ORT side of the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #423: move server scope files to cdn s...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---