You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/01 07:20:43 UTC
[GitHub] [dolphinscheduler] kezhenxu94 opened a new pull request, #11730: Add Kubernetes configmap reload to all components
kezhenxu94 opened a new pull request, #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730
```
[INFO] 2022-09-01 07:15:00.365 +0000 org.apache.dolphinscheduler.server.worker.task.WorkerHeartBeatTask:[86] - [WorkflowInstance-0][TaskInstance-0] - Success write worker group heartBeatInfo into registry, workGroupPath: [/nodes/worker/default/demo-deployment-75b5f8457-ccnck:1234] workerHeartBeatInfo: {"startupTime":1662016367345,"reportTime":1662016500362,"cpuUsage":0.04,"memoryUsage":0.0,"loadAverage":0.17,"availablePhysicalMemorySize":12.96,"maxCpuloadAvg":8.0,"reservedMemory":0.3,"serverStatus":0,"processId":8,"workerHostWeight":100,"workerWaitingTaskCount":0,"workerExecThreadCount":10}
[WARN] 2022-09-01 07:15:03.775 +0000 org.springframework.cloud.kubernetes.fabric8.config.Fabric8ConfigUtils:[121] - [WorkflowInstance-0][TaskInstance-0] - config-map with name : 'standalone-server-kubernetes' not present in namespace : 'default'
[WARN] 2022-09-01 07:15:03.780 +0000 org.springframework.cloud.kubernetes.fabric8.config.Fabric8ConfigUtils:[121] - [WorkflowInstance-0][TaskInstance-0] - config-map with name : 'standalone-server-h2' not present in namespace : 'default'
[INFO] 2022-09-01 07:15:03.781 +0000 org.springframework.cloud.kubernetes.fabric8.config.reload.EventBasedConfigMapChangeDetector:[137] - [WorkflowInstance-0][TaskInstance-0] - Detected change in config maps
[INFO] 2022-09-01 07:15:03.781 +0000 org.springframework.cloud.kubernetes.fabric8.config.reload.EventBasedConfigMapChangeDetector:[61] - [WorkflowInstance-0][TaskInstance-0] - Reloading using strategy: REFRESH
[WARN] 2022-09-01 07:15:04.003 +0000 org.springframework.cloud.kubernetes.fabric8.config.Fabric8ConfigUtils:[121] - [WorkflowInstance-0][TaskInstance-0] - config-map with name : 'standalone-server-kubernetes' not present in namespace : 'default'
[WARN] 2022-09-01 07:15:04.010 +0000 org.springframework.cloud.kubernetes.fabric8.config.Fabric8ConfigUtils:[121] - [WorkflowInstance-0][TaskInstance-0] - config-map with name : 'standalone-server-h2' not present in namespace : 'default'
[INFO] 2022-09-01 07:15:04.011 +0000 org.springframework.cloud.bootstrap.config.PropertySourceBootstrapConfiguration:[109] - [WorkflowInstance-0][TaskInstance-0] - Located property source: [BootstrapPropertySource {name='bootstrapProperties-configmap.standalone-server.default'}]
[INFO] 2022-09-01 07:15:04.017 +0000 org.springframework.boot.SpringApplication:[640] - [WorkflowInstance-0][TaskInstance-0] - The following 2 profiles are active: "kubernetes", "h2"
[INFO] 2022-09-01 07:15:04.050 +0000 org.springframework.boot.SpringApplication:[61] - [WorkflowInstance-0][TaskInstance-0] - Started application in 0.261 seconds (JVM running for 152.919)
[INFO] 2022-09-01 07:15:04.070 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[147] - [WorkflowInstance-0][TaskInstance-0] - Master config: listenPort -> 5678
[INFO] 2022-09-01 07:15:04.070 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[148] - [WorkflowInstance-0][TaskInstance-0] - Master config: fetchCommandNum -> 10
[INFO] 2022-09-01 07:15:04.070 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[149] - [WorkflowInstance-0][TaskInstance-0] - Master config: preExecThreads -> 10
[INFO] 2022-09-01 07:15:04.070 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[150] - [WorkflowInstance-0][TaskInstance-0] - Master config: execThreads -> 10
[INFO] 2022-09-01 07:15:04.071 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[151] - [WorkflowInstance-0][TaskInstance-0] - Master config: dispatchTaskNumber -> 3
[INFO] 2022-09-01 07:15:04.071 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[152] - [WorkflowInstance-0][TaskInstance-0] - Master config: hostSelector -> LOWER_WEIGHT
[INFO] 2022-09-01 07:15:04.071 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[153] - [WorkflowInstance-0][TaskInstance-0] - Master config: heartbeatInterval -> PT10S
[INFO] 2022-09-01 07:15:04.071 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[154] - [WorkflowInstance-0][TaskInstance-0] - Master config: taskCommitRetryTimes -> 5
[INFO] 2022-09-01 07:15:04.071 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[155] - [WorkflowInstance-0][TaskInstance-0] - Master config: taskCommitInterval -> PT1S
[INFO] 2022-09-01 07:15:04.072 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[156] - [WorkflowInstance-0][TaskInstance-0] - Master config: stateWheelInterval -> PT5S
[INFO] 2022-09-01 07:15:04.072 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[157] - [WorkflowInstance-0][TaskInstance-0] - Master config: maxCpuLoadAvg -> 8.0
[INFO] 2022-09-01 07:15:04.072 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[158] - [WorkflowInstance-0][TaskInstance-0] - Master config: reservedMemory -> 0.3
[INFO] 2022-09-01 07:15:04.073 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[159] - [WorkflowInstance-0][TaskInstance-0] - Master config: failoverInterval -> PT10M
[INFO] 2022-09-01 07:15:04.073 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[160] - [WorkflowInstance-0][TaskInstance-0] - Master config: killYarnJobWhenTaskFailover -> true
[INFO] 2022-09-01 07:15:04.073 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[161] - [WorkflowInstance-0][TaskInstance-0] - Master config: registryDisconnectStrategy -> ConnectStrategyProperties(strategy=STOP, maxWaitingTime=PT0S)
[INFO] 2022-09-01 07:15:04.073 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[162] - [WorkflowInstance-0][TaskInstance-0] - Master config: masterAddress -> demo-deployment-75b5f8457-ccnck:5678
[INFO] 2022-09-01 07:15:04.073 +0000 org.apache.dolphinscheduler.server.master.config.MasterConfig:[163] - [WorkflowInstance-0][TaskInstance-0] - Master config: masterRegistryPath -> /nodes/master/demo-deployment-75b5f8457-ccnck:5678
[INFO] 2022-09-01 07:15:04.254 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[100] - [WorkflowInstance-0][TaskInstance-0] - Worker config: listenPort -> 1234
[INFO] 2022-09-01 07:15:04.255 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[101] - [WorkflowInstance-0][TaskInstance-0] - Worker config: execThreads -> 20
[INFO] 2022-09-01 07:15:04.256 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[102] - [WorkflowInstance-0][TaskInstance-0] - Worker config: heartbeatInterval -> PT10S
[INFO] 2022-09-01 07:15:04.257 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[103] - [WorkflowInstance-0][TaskInstance-0] - Worker config: hostWeight -> 100
[INFO] 2022-09-01 07:15:04.258 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[104] - [WorkflowInstance-0][TaskInstance-0] - Worker config: tenantAutoCreate -> true
[INFO] 2022-09-01 07:15:04.259 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[105] - [WorkflowInstance-0][TaskInstance-0] - Worker config: tenantDistributedUser -> false
[INFO] 2022-09-01 07:15:04.259 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[106] - [WorkflowInstance-0][TaskInstance-0] - Worker config: maxCpuLoadAvg -> 8
[INFO] 2022-09-01 07:15:04.260 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[107] - [WorkflowInstance-0][TaskInstance-0] - Worker config: reservedMemory -> 0.3
[INFO] 2022-09-01 07:15:04.260 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[108] - [WorkflowInstance-0][TaskInstance-0] - Worker config: groups -> [default]
[INFO] 2022-09-01 07:15:04.260 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[109] - [WorkflowInstance-0][TaskInstance-0] - Worker config: alertListenHost -> localhost
[INFO] 2022-09-01 07:15:04.261 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[110] - [WorkflowInstance-0][TaskInstance-0] - Worker config: alertListenPort -> 50052
[INFO] 2022-09-01 07:15:04.261 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[111] - [WorkflowInstance-0][TaskInstance-0] - Worker config: registryDisconnectStrategy -> ConnectStrategyProperties(strategy=STOP, maxWaitingTime=PT0S)
[INFO] 2022-09-01 07:15:04.262 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[112] - [WorkflowInstance-0][TaskInstance-0] - Worker config: workerAddress -> ConnectStrategyProperties(strategy=STOP, maxWaitingTime=PT0S)
[INFO] 2022-09-01 07:15:04.262 +0000 org.apache.dolphinscheduler.server.worker.config.WorkerConfig:[113] - [WorkflowInstance-0][TaskInstance-0] - Worker config: workerGroupRegistryPaths: [/nodes/worker/default/demo-deployment-75b5f8457-ccnck:1234]
[INFO] 2022-09-01 07:15:09.042 +0000 org.apache.dolphinscheduler.server.master.task.MasterHeartBeatTask:[68] - [WorkflowInstance-0][TaskInstance-0] - Success write master heartBeatInfo into registry, masterRegistryPath: /nodes/master/demo-deployment-75b5f8457-ccnck:5678, heartBeatInfo: {"startupTime":1662016367345,"reportTime":1662016509037,"cpuUsage":0.08,"memoryUsage":0.0,"loadAverage":0.16,"availablePhysicalMemorySize":12.96,"maxCpuloadAvg":8.0,"reservedMemory":0.3,"processId":8}
[INFO] 2022-09-01 07:15:10.371 +0000 org.apache.dolphinscheduler.server.worker.task.WorkerHeartBeatTask:[86] - [WorkflowInstance-0][TaskInstance-0] - Success write worker group heartBeatInfo into registry, workGroupPath: [/nodes/worker/default/demo-deployment-75b5f8457-ccnck:1234] workerHeartBeatInfo: {"startupTime":1662016367345,"reportTime":1662016510366,"cpuUsage":0.02,"memoryUsage":0.0,"loadAverage":0.14,"availablePhysicalMemorySize":12.96,"maxCpuloadAvg":8.0,"reservedMemory":0.3,"serverStatus":0,"processId":8,"workerHostWeight":100,"workerWaitingTaskCount":0,"workerExecThreadCount":20}
```
As we can see `Detected change in config maps` and `Reloading using strategy: REFRESH`, and from the log `workerExecThreadCount":10` to `workerExecThreadCount":20` when I modify the config map to change the `workerExecThreadCount` from `10` to `20`.
Now all these work out of box in Kubernetes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11730: Add Kubernetes configmap reload to all components
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730#issuecomment-1234301643
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11730)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #11730: Add Kubernetes configmap reload to all components
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730#issuecomment-1233856888
All works as before, when users want to change the configuration, just create a patch config like this, and it's all done.
```shell
cat <<EOF | kubectl apply -f -
apiVersion: v1
data:
application.yml: |-
worker:
exec-threads: 30
kind: ConfigMap
metadata:
name: standalone-server
namespace: default
EOF
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11730: Add Kubernetes configmap reload to all components
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730#issuecomment-1235023172
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11730)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #11730: Add Kubernetes configmap reload to all components
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730#issuecomment-1234287818
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/11730?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11730](https://codecov.io/gh/apache/dolphinscheduler/pull/11730?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f88feec) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/d0f5e7edf34a71e31bd2f5fa376bf235b395ec7d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0f5e7e) will **decrease** coverage by `0.08%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## dev #11730 +/- ##
============================================
- Coverage 39.73% 39.64% -0.09%
+ Complexity 4709 4688 -21
============================================
Files 1008 1008
Lines 37878 37863 -15
Branches 4238 4230 -8
============================================
- Hits 15049 15012 -37
- Misses 21218 21245 +27
+ Partials 1611 1606 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/11730?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inscheduler/server/log/LoggerRequestProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1sb2ctc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZlci9sb2cvTG9nZ2VyUmVxdWVzdFByb2Nlc3Nvci5qYXZh) | `17.30% <0.00%> (-0.52%)` | :arrow_down: |
| [...eduler/server/worker/task/WorkerHeartBeatTask.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1dvcmtlckhlYXJ0QmVhdFRhc2suamF2YQ==) | `68.08% <0.00%> (-8.52%)` | :arrow_down: |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [...erver/master/processor/queue/TaskEventService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza0V2ZW50U2VydmljZS5qYXZh) | `75.00% <0.00%> (-5.36%)` | :arrow_down: |
| [...r/plugin/task/sqoop/parameter/SqoopParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stc3Fvb3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svc3Fvb3AvcGFyYW1ldGVyL1Nxb29wUGFyYW1ldGVycy5qYXZh) | `55.12% <0.00%> (-1.29%)` | :arrow_down: |
| [...rver/master/runner/task/BlockingTaskProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvdGFzay9CbG9ja2luZ1Rhc2tQcm9jZXNzb3IuamF2YQ==) | `75.86% <0.00%> (-0.55%)` | :arrow_down: |
| [...eduler/api/service/impl/DataSourceServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9EYXRhU291cmNlU2VydmljZUltcGwuamF2YQ==) | `27.90% <0.00%> (ø)` | |
| [...cheduler/server/master/utils/DependentExecute.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci91dGlscy9EZXBlbmRlbnRFeGVjdXRlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ache/dolphinscheduler/plugin/task/k8s/K8sTask.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stazhzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi90YXNrL2s4cy9LOHNUYXNrLmphdmE=) | `89.47% <0.00%> (ø)` | |
| [.../dolphinscheduler/plugin/task/datax/DataxTask.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stZGF0YXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svZGF0YXgvRGF0YXhUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/dolphinscheduler/pull/11730/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11730: Add Kubernetes configmap reload to all components
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730#discussion_r961239135
##########
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/resources/bootstrap.yaml:
##########
@@ -0,0 +1,28 @@
+#
Review Comment:
Since we have a new `bootstrap.yaml` configuration for all components, do we need to update https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/architecture/configuration.md and add some related instructions?
##########
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/resources/bootstrap.yaml:
##########
@@ -0,0 +1,28 @@
+#
Review Comment:
Since we have a new `bootstrap.yaml` configuration file for all components, do we need to update https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/architecture/configuration.md and add some related instructions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11730: Add Kubernetes configmap reload to all components
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730#issuecomment-1235025250
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11730)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11730: Add Kubernetes configmap reload to all components
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730#issuecomment-1234294714
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11730)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11730&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11730&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11730: Add Kubernetes configmap reload to all components
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730#discussion_r961244380
##########
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/resources/bootstrap.yaml:
##########
@@ -0,0 +1,28 @@
+#
Review Comment:
> Since we have a new `bootstrap.yaml` configuration file for all components, do we need to update https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/architecture/configuration.md and add some related instructions?
Thank you, I've updated those two docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 merged pull request #11730: Add Kubernetes configmap reload to all components
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged PR #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org