You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/06 16:05:49 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #11024: KAFKA-13065: Replace EasyMock with Mockito for BasicAuthSecurityRestExtensionTest

ijuma commented on a change in pull request #11024:
URL: https://github.com/apache/kafka/pull/11024#discussion_r702993808



##########
File path: connect/basic-auth-extension/src/test/java/org/apache/kafka/connect/rest/basic/auth/extension/BasicAuthSecurityRestExtensionTest.java
##########
@@ -37,9 +39,15 @@
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
 
+@ExtendWith(MockitoExtension.class)
 public class BasicAuthSecurityRestExtensionTest {
 
+    @Mock
+    Configurable<? extends Configurable<?>> configurable;

Review comment:
       Why did we make this a field even though it's only used in the one test?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org