You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/12/21 21:09:16 UTC
[GitHub] [accumulo] dlmarion opened a new pull request #2398: Make CreateEmpty utility extend KeywordExecutable
dlmarion opened a new pull request #2398:
URL: https://github.com/apache/accumulo/pull/2398
Closes #2360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on a change in pull request #2398: Make CreateEmpty utility extend KeywordExecutable
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on a change in pull request #2398:
URL: https://github.com/apache/accumulo/pull/2398#discussion_r773454733
##########
File path: core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java
##########
@@ -40,7 +41,7 @@
* Create an empty RFile for use in recovering from data loss where Accumulo still refers internally
* to a path.
*/
-public class CreateEmpty {
+public class CreateEmpty implements KeywordExecutable {
Review comment:
```suggestion
@AutoService(KeywordExecutable.class)
public class CreateEmpty implements KeywordExecutable {
```
Should this be added here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a change in pull request #2398: Make CreateEmpty implement KeywordExecutable
Posted by GitBox <gi...@apache.org>.
dlmarion commented on a change in pull request #2398:
URL: https://github.com/apache/accumulo/pull/2398#discussion_r773844791
##########
File path: core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java
##########
@@ -40,7 +41,7 @@
* Create an empty RFile for use in recovering from data loss where Accumulo still refers internally
* to a path.
*/
-public class CreateEmpty {
+public class CreateEmpty implements KeywordExecutable {
Review comment:
Yep, thanks. I forgot the annotation. I updated both PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2398: Make CreateEmpty implement KeywordExecutable
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2398:
URL: https://github.com/apache/accumulo/pull/2398#issuecomment-999570275
This one will probably need to be added to KeywordStartIT as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on a change in pull request #2398: Make CreateEmpty implement KeywordExecutable
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on a change in pull request #2398:
URL: https://github.com/apache/accumulo/pull/2398#discussion_r774042801
##########
File path: core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java
##########
@@ -76,10 +79,25 @@ public void validate(String name, String value) throws ParameterException {
}
public static void main(String[] args) throws Exception {
+ new CreateEmpty().execute(args);
+ }
+
+ @Override
+ public String keyword() {
+ return "create-empty";
+ }
+
+ @Override
+ public String description() {
+ return "creates an empty rfile";
Review comment:
```suggestion
return "Creates an empty rfile";
```
The rest of the descriptions start with a capital letter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #2398: Make CreateEmpty implement KeywordExecutable
Posted by GitBox <gi...@apache.org>.
dlmarion merged pull request #2398:
URL: https://github.com/apache/accumulo/pull/2398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org