You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/17 15:04:37 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #24528: Do not calculate grid root instances

ashb commented on code in PR #24528:
URL: https://github.com/apache/airflow/pull/24528#discussion_r900209358


##########
airflow/www/views.py:
##########
@@ -387,6 +387,14 @@ def get_summary(dag_run, children):
                 'end_date': group_end_date,
             }
 
+        # We don't need to calculate summaries for the root
+        if task_group.group_id is None:
+            return {
+                'id': task_group.group_id,
+                'children': children,
+                'instances': [],

Review Comment:
   Will not having `label` here confuse your Typescript changes in the UI? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org