[GitHub] [couchdb] davisp commented on pull request #3337: Simplify and speedup dev node startup

[GitBox <gi...@apache.org>]

davisp commented on pull request #3337:
URL: https://github.com/apache/couchdb/pull/3337#issuecomment-764744445


   It looks like this is the diff that black (the python formatter/linter) is suggesting:
   
   ```diff
   diff --git a/dev/run b/dev/run
   index 476ec3682..7af718afa 100755
   --- a/dev/run
   +++ b/dev/run
   @@ -190,7 +190,7 @@ def get_args_parser():
            "--erlang-config",
            dest="erlang_config",
            default="rel/files/sys.config",
   -        help="Specify an alternative Erlang application configuration"
   +        help="Specify an alternative Erlang application configuration",
        )
        parser.add_option(
            "--degrade-cluster",
   @@ -275,6 +275,7 @@ def check_beams(ctx):
        for fname in glob.glob(os.path.join(ctx["devdir"], "*.erl")):
            sp.check_call(["erlc", "-o", ctx["devdir"] + os.sep, fname])
    
   +
    @log("Ensure Erlang boot script exists")
    def check_boot_script(ctx):
        if not os.path.exists(os.path.join(ctx["devdir"], "devnode.boot")):
   @@ -282,6 +283,7 @@ def check_boot_script(ctx):
            env["ERL_LIBS"] = os.path.join(ctx["rootdir"], "src")
            sp.check_call(["escript", "make_boot_script"], env=env, cwd=ctx["devdir"])
    
   +
    @log("Prepare configuration files")
    def setup_configs(ctx):
        for idx, node in enumerate(ctx["nodes"]):
   @@ -631,7 +633,7 @@ def boot_node(ctx, node):
            os.path.join(ctx["devdir"], "devnode"),
            "-pa",
            ctx["devdir"],
   -        "-s monitor_parent"
   +        "-s monitor_parent",
        ]
        if ctx["reset_logs"]:
            mode = "wb"
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org