You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2007/01/15 09:30:27 UTC
[jira] Commented: (HARMONY-2822) [classlib][swing]
javax.swing.plaf.basic.BasicFileChooserUI.installDefaults(null) returns
null while RI throws NPE
[ https://issues.apache.org/jira/browse/HARMONY-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464684 ]
Mark Hindess commented on HARMONY-2822:
---------------------------------------
Is the test really correct? I see two code paths which will result in a pass... one with the '// PASSED' comment and one with the "ae.printStackTrace();". The "ae.printStackTrace();" needs to go anyway since we shouldn't be verbose in tests.
> [classlib][swing] javax.swing.plaf.basic.BasicFileChooserUI.installDefaults(null) returns null while RI throws NPE
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2822
> URL: https://issues.apache.org/jira/browse/HARMONY-2822
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oleg Khaschansky
> Priority: Minor
> Attachments: Harmony-2822-BasicFileChooserUI.patch, Harmony-2822-BasicFileChooserUITest.patch
>
>
> javax.swing.plaf.basic.BasicFileChooserUI.installDefaults(null) returns null on Harmony while RI throws NPE.
> Current implementation of BasicFileChooserUI.installDefaults(JFileChooser fc) simply ignores the parameter, so it doesn't throw this unspecified NPE. I suggest to treat this as a non-bug difference.
> The following testcase demonstrates this behavior:
> --------------------------------------------------------------------------------------
> import junit.framework.TestCase;
> import javax.swing.plaf.basic.BasicFileChooserUI;
> import javax.swing.*;
> import java.lang.reflect.InvocationTargetException;
> public class Test0 extends TestCase {
> public void testcase1() {
> BasicFileChooserUI jm = new BasicFileChooserUI(null);
> java.lang.reflect.Method mt = null;
> Class cls = BasicFileChooserUI.class;
> try{
> mt = cls.getDeclaredMethod( "installDefaults", JFileChooser.class);
> } catch(Exception e) {
> e.printStackTrace();
> }
> mt.setAccessible(true);
> Object[] obj ={null};
> try {
> mt.invoke(jm, obj );
> fail("NPE should be thrown");
> } catch ( IllegalAccessException ae) {
> ae.printStackTrace();
> } catch ( InvocationTargetException ie) {
> }
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira