You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/01/14 17:41:00 UTC

[jira] [Commented] (GEODE-9936) Throw error for commands with multiple keys that contain the wrong type key

    [ https://issues.apache.org/jira/browse/GEODE-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476295#comment-17476295 ] 

ASF subversion and git services commented on GEODE-9936:
--------------------------------------------------------

Commit 742cf33dfe570b7a6e47a622ed1b18bf016def0d in geode's branch refs/heads/develop from Kris10
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=742cf33 ]

GEODE-9936: Modify multi-key Redis commands for wrong type key (#7257)

 - For Redis commands that take in multiple keys, added tests with the wrong key type as an argument.
 - Modified the implementation of SDIFF, SDIFFSTORE, and ZINTERSTORE to prevent early returns allowing all keys to check for wrong key types.
 - Updated variables to match coding style.

> Throw error for commands with multiple keys that contain the wrong type key
> ---------------------------------------------------------------------------
>
>                 Key: GEODE-9936
>                 URL: https://issues.apache.org/jira/browse/GEODE-9936
>             Project: Geode
>          Issue Type: Bug
>          Components: redis
>            Reporter: Kristen
>            Assignee: Kristen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> For commands that take in multiple keys as arguments, it does not throw an error if the arguments consist of a valid key followed by a different type key.
> Fix it so a wrong type error is thrown and add two test. One test should takes in valid key followed by a different type key. Then the other test should switch the ordering of the keys. 
> The following commands need to be checked: ZUNIONSTORE, ZINTERSTORE, SMOVE, SDIFF, and SDIFFSTORE



--
This message was sent by Atlassian Jira
(v8.20.1#820001)