You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2022/01/18 20:09:03 UTC
[GitHub] [tika] lewismc commented on a change in pull request #478: Stat analysis core
lewismc commented on a change in pull request #478:
URL: https://github.com/apache/tika/pull/478#discussion_r787111153
##########
File path: tika-core/src/main/java/org/apache/tika/language/detect/LanguageNames.java
##########
@@ -42,13 +42,13 @@ public static String normalizeName(String languageTag) {
}
public static boolean isMacroLanguage(String languageTag) {
- Locale locale = Locale.forLanguageTag(languageTag);
+ // Locale locale = Locale.forLanguageTag(languageTag); unused
Review comment:
Why not just remove?
##########
File path: tika-core/src/main/java/org/apache/tika/language/detect/LanguageNames.java
##########
@@ -42,13 +42,13 @@ public static String normalizeName(String languageTag) {
}
public static boolean isMacroLanguage(String languageTag) {
- Locale locale = Locale.forLanguageTag(languageTag);
+ // Locale locale = Locale.forLanguageTag(languageTag); unused
// TODO make it so.
return false;
}
public static boolean hasMacroLanguage(String languageTag) {
- Locale locale = Locale.forLanguageTag(languageTag);
+ // Locale locale = Locale.forLanguageTag(languageTag); // unused
Review comment:
Why not just remove?
##########
File path: tika-core/src/main/java/org/apache/tika/parser/RecursiveParserWrapper.java
##########
@@ -145,7 +145,7 @@ public void parse(InputStream stream, ContentHandler recursiveParserWrapperHandl
int writeLimit = -1;
//TODO -- rely on a new interface WriteLimiting...?
//It'd be better not to tie this to a specific class
- if (recursiveParserWrapperHandler instanceof BasicContentHandlerFactory) {
+ if (recursiveParserWrapperHandler instanceof BasicContentHandlerFactory) { // TODO this cond is always false
Review comment:
Do you want to open a JIRA ticket if this is a problem?
##########
File path: tika-core/src/main/java/org/apache/tika/utils/AnnotationUtils.java
##########
@@ -109,10 +107,10 @@ public static void assignFieldParams(Object bean, Map<String, Param> params)
List<ParamField> fields = PARAM_INFO.get(beanClass);
- Set<String> validFieldNames = new HashSet<>();
+ //Set<String> validFieldNames = new HashSet<>(); // unused
Review comment:
Why not just remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org