You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2009/08/25 23:58:49 UTC

svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Author: wrowe
Date: Tue Aug 25 21:58:49 2009
New Revision: 807823

URL: http://svn.apache.org/viewvc?rev=807823&view=rev
Log:
suppose this would be worth noting

Modified:
    httpd/mod_fcgid/trunk/CHANGES-FCGID

Modified: httpd/mod_fcgid/trunk/CHANGES-FCGID
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/CHANGES-FCGID?rev=807823&r1=807822&r2=807823&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/CHANGES-FCGID [utf8] (original)
+++ httpd/mod_fcgid/trunk/CHANGES-FCGID [utf8] Tue Aug 25 21:58:49 2009
@@ -1,6 +1,8 @@
                                                          -*- coding: utf-8 -*-
 Changes with mod_fcgid 2.3.1
 
+  *) Complete the unix port to 2.3-dev trunk.  [William Rowe]
+
   *) Provide a default, mandatory environment as with mod_cgi (with the
      inclusion of LD_LIBRARY_PATH or similar variables on other platforms),
      unless overridden by DefaultInitEnv.  [William Rowe]



Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Posted by Jeff Trawick <tr...@gmail.com>.
On Wed, Aug 26, 2009 at 12:56 PM, William A. Rowe, Jr.
<wr...@rowe-clan.net>wrote:

> William A. Rowe, Jr. wrote:
> > Jeff Trawick wrote:
> >> (brain dump since I have to get some real work done)
> >
> > :)
> >
> >> Here's a patch to get the proper header files included for the apr 0.9.x
> >> compatibility code.
>
> And if I wasn't clear, please feel free to dump this into svn, I'll assure
> it doesn't break anything before I tag and roll.


Yep (I'll take a few minutes to fix/test further based on your comments.)


>
> We gotta keep your stats up in Tomislav's analysis :)


Yes, André is breathing down my neck.

Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> Jeff Trawick wrote:
>> (brain dump since I have to get some real work done)
> 
> :)
> 
>> Here's a patch to get the proper header files included for the apr 0.9.x
>> compatibility code.

And if I wasn't clear, please feel free to dump this into svn, I'll assure
it doesn't break anything before I tag and roll.

We gotta keep your stats up in Tomislav's analysis :)

Bill

Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Jeff Trawick wrote:
> 
> (brain dump since I have to get some real work done)

:)

> Here's a patch to get the proper header files included for the apr 0.9.x
> compatibility code.
> 
> http://people.apache.org/~trawick/fcgid_2.0.x_detect.patch
> 
> Is it worth the trouble to make that ugly code (copy of apr_shm_remove)
> compile correctly?  Should we just add that function to the
> not-anally-versioned APR 0.9.x?

Sure.  Let's get it building correctly without updating 0.9.x; it serves
as a good example of this module build schema.  The four lines of fchmod
example in configure.apxs be deleted.  And it appears there is a stray ')'
at the end of your revised APACHE_MODULE line.

Just need to strip all these checks when brought into httpd trunk,
if we do so.

> My configure.apxs build currently fails to find mod_fcgid.a; that
> doesn't seem to be related to the patch, but that knowledge
> brings only so much happiness...  And I haven't tried building in-tree.

:)  How does modules.mk from .apxs compare with a normal modules.mk that
would exist in one of your modules/ subdirectories of a normal 2.0 build?
Is it invoking the right libtool (copied into apr/build/)?  There are some
flaws in the httpd-2.0 installation still, particularly if apr ends up
installed in a different directory than httpd.

Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Posted by Jeff Trawick <tr...@gmail.com>.
On Wed, Aug 26, 2009 at 1:10 AM, William A. Rowe, Jr.
<wr...@rowe-clan.net>wrote:

> Chris Darroch wrote:
> > wrowe@apache.org wrote:
> >
> >> URL: http://svn.apache.org/viewvc?rev=807823&view=rev
> >> Log:
> >> suppose this would be worth noting
> >
> >>  Changes with mod_fcgid 2.3.1
> >>
> >> +  *) Complete the unix port to 2.3-dev trunk.  [William Rowe]
> >
> >   Thank you for all this work ... it's much appreciated, especially
> > since I've been utterly useless lately on the httpd front.  Thanks again!
>
> So... if I throw the effort at getting unix to build clean for httpd-2.0
> branch, you won't be offended ;-?


(brain dump since I have to get some real work done)

Here's a patch to get the proper header files included for the apr 0.9.x
compatibility code.

http://people.apache.org/~trawick/fcgid_2.0.x_detect.patch

Is it worth the trouble to make that ugly code (copy of apr_shm_remove)
compile correctly?  Should we just add that function to the
not-anally-versioned APR 0.9.x?

My configure.apxs build currently fails to find mod_fcgid.a; that doesn't
seem to be related to the patch, but that knowledge brings only so much
happiness...  And I haven't tried building in-tree.

Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Posted by Chris Darroch <ch...@pearsoncmg.com>.
William A. Rowe, Jr. wrote:

>>   Thank you for all this work ... it's much appreciated, especially
>> since I've been utterly useless lately on the httpd front.  Thanks again!
> 
> So... if I throw the effort at getting unix to build clean for httpd-2.0
> branch, you won't be offended ;-?
> 
> Seriously, no troubles, I'd just like to see this released, so we get
> bug reports, so that we fix them, so that this becomes more relevant
> and ends up in the 2.3-dev tree :)

   Absolutely, and again, apologies for being a useless lump at the
moment.

> I'm rolling sometime tomorrow.  If folks can check out, test compile
> and experiment, I'd be most appreciative.  It would be lovely if it
> could go GA on the first try.

   I can't make a promise but I'll try to grab it and spin it up.
Again, thank you.

Chris.

-- 
GPG Key ID: 366A375B
GPG Key Fingerprint: 485E 5041 17E1 E2BB C263  E4DE C8E3 FA36 366A 375B


Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Posted by "Gregg L. Smith" <li...@glewis.com>.
Hi Bill,

Since I had tossed it all you forced me to rebuild. I do not remember 
doing anything different prior but

The Culprit;
 >
 > My usual disclaimer, I will not deny this may possibly be my fault.
 >

Sorry and Thanks for getting this module going. I can think of a lot of 
people that will be very happy now that the ASF has taken it over.

Gregg


William A. Rowe, Jr. wrote:
> Gregg L. Smith wrote:
>> Faulting application httpd.exe, version 2.2.13.0, faulting module
>> libapr-1.dll, version 1.3.8.0, fault address 0x0000793d.
> 
> Gregg, your Dr Watson or windbg fault backtrace please?
> 
> 
> ------------------------------------------------------------------------
> 
> 
> No virus found in this incoming message.
> Checked by AVG - www.avg.com 
> Version: 8.5.392 / Virus Database: 270.13.69/2328 - Release Date: 08/26/09 12:16:00
> 


Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Gregg L. Smith wrote:
> Faulting application httpd.exe, version 2.2.13.0, faulting module
> libapr-1.dll, version 1.3.8.0, fault address 0x0000793d.

Gregg, your Dr Watson or windbg fault backtrace please?

Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Posted by "Gregg L. Smith" <li...@glewis.com>.
Hi Bill and Chris,

Question, is this going to work with APR 1.3 on Windows? I see this
http://svn.apache.org/viewvc?view=rev&revision=787561

but when I look at what I was given by Tom Donovan he seemed to have to 
deal with APR 1.3 as a #if seperate entity #endif, nasty yes but it 
works. My build out-of-tree on the 19th builds and loads fine but when 
it is called upon it did this;

Faulting application httpd.exe, version 2.2.13.0, faulting module
libapr-1.dll, version 1.3.8.0, fault address 0x0000793d.

This failure in libapr-1.dll leave me a bit suspicious.

My usual disclaimer, I will not deny this may possibly be my fault.

Regards,
Gregg



William A. Rowe, Jr. wrote:
> Chris Darroch wrote:
>> wrowe@apache.org wrote:
>>
>>> URL: http://svn.apache.org/viewvc?rev=807823&view=rev
>>> Log:
>>> suppose this would be worth noting
>>>  Changes with mod_fcgid 2.3.1
>>>  
> 
> I'm rolling sometime tomorrow.  If folks can check out, test compile
> and experiment, I'd be most appreciative.  It would be lovely if it
> could go GA on the first try.
> 



Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Chris Darroch wrote:
> wrowe@apache.org wrote:
> 
>> URL: http://svn.apache.org/viewvc?rev=807823&view=rev
>> Log:
>> suppose this would be worth noting
> 
>>  Changes with mod_fcgid 2.3.1
>>  
>> +  *) Complete the unix port to 2.3-dev trunk.  [William Rowe]
> 
>   Thank you for all this work ... it's much appreciated, especially
> since I've been utterly useless lately on the httpd front.  Thanks again!

So... if I throw the effort at getting unix to build clean for httpd-2.0
branch, you won't be offended ;-?

Seriously, no troubles, I'd just like to see this released, so we get
bug reports, so that we fix them, so that this becomes more relevant
and ends up in the 2.3-dev tree :)

I'm rolling sometime tomorrow.  If folks can check out, test compile
and experiment, I'd be most appreciative.  It would be lovely if it
could go GA on the first try.

Re: svn commit: r807823 - /httpd/mod_fcgid/trunk/CHANGES-FCGID

Posted by Chris Darroch <ch...@pearsoncmg.com>.
wrowe@apache.org wrote:

> URL: http://svn.apache.org/viewvc?rev=807823&view=rev
> Log:
> suppose this would be worth noting

>  Changes with mod_fcgid 2.3.1
>  
> +  *) Complete the unix port to 2.3-dev trunk.  [William Rowe]

   Thank you for all this work ... it's much appreciated, especially
since I've been utterly useless lately on the httpd front.  Thanks again!

Chris.

-- 
GPG Key ID: 366A375B
GPG Key Fingerprint: 485E 5041 17E1 E2BB C263  E4DE C8E3 FA36 366A 375B