You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/08/12 22:08:34 UTC
Review Request 37410: Disallow copy construction/assignment
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37410/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
Description
-------
Disallow copy construction/assignment for the Mesos scheduler library.
Diffs
-----
include/mesos/v1/scheduler.hpp b3f4484b06dfd6b967d934fd39be373cbff445c4
Diff: https://reviews.apache.org/r/37410/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 37410: Disallow copy construction/assignment
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37410/#review95170
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37410]
All tests passed.
- Mesos ReviewBot
On Aug. 12, 2015, 8:08 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37410/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 8:08 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disallow copy construction/assignment for the Mesos scheduler library.
>
>
> Diffs
> -----
>
> include/mesos/v1/scheduler.hpp b3f4484b06dfd6b967d934fd39be373cbff445c4
>
> Diff: https://reviews.apache.org/r/37410/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37410: Disallow copy construction/assignment
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37410/
-----------------------------------------------------------
(Updated Aug. 16, 2015, 8:40 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Rebased
Repository: mesos
Description
-------
Disallow copy construction/assignment for the Mesos scheduler library.
Diffs (updated)
-----
include/mesos/v1/scheduler.hpp c939de3777fd52dae313a012987e29f35d17b1fc
Diff: https://reviews.apache.org/r/37410/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 37410: Disallow copy construction/assignment
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37410/#review95169
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 12, 2015, 8:08 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37410/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 8:08 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disallow copy construction/assignment for the Mesos scheduler library.
>
>
> Diffs
> -----
>
> include/mesos/v1/scheduler.hpp b3f4484b06dfd6b967d934fd39be373cbff445c4
>
> Diff: https://reviews.apache.org/r/37410/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>