You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org> on 2019/10/22 22:29:43 UTC
[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Xiaomeng Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14531
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container
......................................................................
IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Original we get /proc/version dispalyed as OS version, while it's
actually kernel version. We should correct it as Kernel version,
and display OS version from /etc/os-release.
Tested locally, the displayed OS Info in localhost:25020 is:
OS version: "Ubuntu 16.04.6 LTS"
Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC
Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
---
M be/src/util/os-info.cc
M be/src/util/os-info.h
2 files changed, 29 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/1
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
......................................................................
Patch Set 9: Code-Review+2
Thanks Xiaomeng LGTM
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 19:33:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
......................................................................
Patch Set 10: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5283/
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Nov 2019 00:48:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14531/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14531/3//COMMIT_MSG@15
PS3, Line 15: OS version: "Ubuntu 16.04.6 LTS"
> That's coming from the original file.
OK, but we should make it pretty
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 18:58:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
......................................................................
Patch Set 6:
(2 comments)
Still a few things to think about...
http://gerrit.cloudera.org:8080/#/c/14531/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14531/6//COMMIT_MSG@7
PS6, Line 7: IMPALA-8065 Edit OS version and Kernel version in OSInfo
Can you improve this one line description? Why is it Edit?
http://gerrit.cloudera.org:8080/#/c/14531/6/be/src/util/os-info.cc
File be/src/util/os-info.cc:
http://gerrit.cloudera.org:8080/#/c/14531/6/be/src/util/os-info.cc@72
PS6, Line 72: if (fields[0].compare("PRETTY_NAME") == 0) {
Will this work on Centos6?
https://www.liquidweb.com/kb/how-to-check-your-centos-version/
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 18:08:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4922/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 23:52:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4955/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 22:57:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
......................................................................
IMPALA-8065 Edit OS version and Kernel version in OSInfo
Before this change OsInfo::DebugString() would print two lines:
- OS version: the long name of the Linux kernel from /proc/version
- Clock: the type of clock used
After this change OsInfo::DebugString() will print three lines:
- OS version: the short name of the OS release.
If Docker is being used this is the name of the Container OS
- Kernel version: the long name of the Linux kernel from /proc/version.
If Docker is being used this is the description of the Host Kernel.
- Clock: the type of clock used.
Tested locally, the displayed OS Info in Ubuntu16 dev box is:
OS version: "Ubuntu 16.04.6 LTS"
Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC
Also tested with diff OS in docker: centos, redhat, ubuntu, oracle,
debian. Each OS picked one version to test.
Added new backend test os-info-test.cc.
Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
---
M be/src/util/CMakeLists.txt
A be/src/util/os-info-test.cc
M be/src/util/os-info.cc
M be/src/util/os-info.h
4 files changed, 75 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/4
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8065 Add OS version and Kernel version in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Add OS version and Kernel version in OSInfo
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4914/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Oct 2019 23:54:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
......................................................................
IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Before this change OsInfo::DebugString() would print two lines:
- OS version: the long name of the Linux kernel from /proc/version
- Clock: the type of clock used
After this change OsInfo::DebugString() will print three lines:
- OS version: the short name of the OS release.
If Docker is being used this is the name of the Container OS
- Kernel version: the long name of the Linux kernel from /proc/version.
If Docker is being used this is the description of the Host Kernel.
- Clock: the type of clock used.
Tested locally, the displayed OS Info in Ubuntu16 dev box is:
OS version: Ubuntu 16.04.6 LTS
Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC
Also checked with diff OS in docker: centos, redhat, ubuntu, oracle,
debian to make sure /etc/os-release exists and PRETTY_NAME in that file.
Each OS picked one version to test.
Specially for centos6, which has centos-release instead of os-release,
copied centos-release into Ubuntu16 dev box and verified os version in
mini-cluster.
Added new backend test os-info-test.cc.
Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
---
M be/src/util/CMakeLists.txt
A be/src/util/os-info-test.cc
M be/src/util/os-info.cc
M be/src/util/os-info.h
4 files changed, 80 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/8
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container
......................................................................
IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Original we get /proc/version dispalyed as OS version, while it's
actually kernel version. We should correct it as Kernel version,
and display OS version from /etc/os-release (for centos6 it's
/etc/centos-release).
Tested locally, the displayed OS Info in localhost:25020 is:
OS version: "Ubuntu 16.04.6 LTS"
Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC
Also tested with diff OS in docker: centos, redhat, ubuntu, oracle,
debian. Each OS picked one version to test.
Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
---
M be/src/util/os-info.cc
M be/src/util/os-info.h
2 files changed, 39 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/2
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
......................................................................
IMPALA-8065 Edit OS version and Kernel version in OSInfo
Before this change OsInfo::DebugString() would print two lines:
- OS version: the long name of the Linux kernel from /proc/version
- Clock: the type of clock used
After this change OsInfo::DebugString() will print three lines:
- OS version: the short name of the OS release.
If Docker is being used this is the name of the Container OS
- Kernel version: the long name of the Linux kernel from /proc/version.
If Docker is being used this is the description of the Host Kernel.
- Clock: the type of clock used.
Tested locally, the displayed OS Info in Ubuntu16 dev box is:
OS version: "Ubuntu 16.04.6 LTS"
Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC
Also tested with diff OS in docker: centos, redhat, ubuntu, oracle,
debian. Each OS picked one version to test.
Added new backend test os-info-test.cc.
Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
---
M be/src/util/CMakeLists.txt
A be/src/util/os-info-test.cc
M be/src/util/os-info.cc
M be/src/util/os-info.h
4 files changed, 77 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/5
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5150/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Oct 2019 21:55:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4855/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Oct 2019 23:14:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Oct 2019 02:31:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
......................................................................
Patch Set 7:
(3 comments)
Getting really close :-)
http://gerrit.cloudera.org:8080/#/c/14531/7//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14531/7//COMMIT_MSG@26
PS7, Line 26: debian. Each OS picked one version to test.
I think you must have some some extra testing on Centos6, you could add a not about it here
http://gerrit.cloudera.org:8080/#/c/14531/7/be/src/util/os-info-test.cc
File be/src/util/os-info-test.cc:
http://gerrit.cloudera.org:8080/#/c/14531/7/be/src/util/os-info-test.cc@27
PS7, Line 27: ASSERT_NE(osinfo.kernel_version(), "Unknown");
Add a similar test for fast_clock()?
http://gerrit.cloudera.org:8080/#/c/14531/7/be/src/util/os-info.cc
File be/src/util/os-info.cc:
http://gerrit.cloudera.org:8080/#/c/14531/7/be/src/util/os-info.cc@67
PS7, Line 67: os_version_.erase(remove(os_version_.begin(), os_version_.end(), '\"'),
Add a 1-line comment explaining what is happening?
You may want to run clang-format again on this method.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 19:52:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4921/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 23:50:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc
File be/src/util/os-info.cc:
http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc@56
PS1, Line 56: ifstream os_version("/etc/os-release", ios::in);
> I think this file is not present on Centos6.
Thanks for finding this. I picked one version for each OS testing, which missed the special centos6. Added a catch up for case /etc/os-release doesn't exist.
http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc@99
PS1, Line 99: << "Kernel version: " << kernel_version_ << endl
> If I were reading this I would be confused: what is OS version, what is Ker
OS version is distribution version, and kerbel version is linux version. I don't have a better idea of distinguish them.
For docker display, I search online, there is no guaranteed way to find it's running in a docker container. There are all kinds situation and we don't want to provide wrong info.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Oct 2019 21:44:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
......................................................................
IMPALA-8065: Add OS distribution name in OSInfo
Before this change OsInfo::DebugString() would print two lines:
- OS version: the long name of the Linux kernel from /proc/version
- Clock: the type of clock used
After this change OsInfo::DebugString() will print three lines:
- OS distribution: the short name of the OS release.
If Docker is being used this is the name of the Container OS.
- OS version: the long name of the Linux kernel from /proc/version.
If Docker is being used this is the description of the Host Kernel.
- Clock: the type of clock used.
Tested locally, the displayed OS Info in Ubuntu16 dev box is:
OS distribution: Ubuntu 16.04.6 LTS
OS version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC
Also checked with diff OS in docker: centos, redhat, ubuntu, oracle,
debian to make sure /etc/os-release exists and PRETTY_NAME in that file.
Each OS picked one version to test.
Specially for centos6 and redhat6, which have redhat-release instead of
os-release, copied redhat-release into Ubuntu16 dev box and verified os
version in mini-cluster.
Added new backend test os-info-test.cc.
Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Reviewed-on: http://gerrit.cloudera.org:8080/14531
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/CMakeLists.txt
A be/src/util/os-info-test.cc
M be/src/util/os-info.cc
M be/src/util/os-info.h
4 files changed, 82 insertions(+), 8 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8065 Add OS version and Kernel version in OSInfo
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Add OS version and Kernel version in OSInfo
......................................................................
Patch Set 3:
(8 comments)
Code looks good, Comments and commit message need more work, I think
http://gerrit.cloudera.org:8080/#/c/14531/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14531/3//COMMIT_MSG@8
PS3, Line 8:
I think it is important to write a commit message that can be understood
by someone who has not read the code you are changing. Sometimes it
helps to explain what the code is.
OsInfo is used to get human readable information about the OS on which
Impala is running.
Before this change OsInfo::DebugString() would print two lines:
- OS version: the long name of the Linux kernel from /proc/version
- Clock: the type of clock used
After this change OsInfo::DebugString() will print three lines:
- OS version: the short name of the Linux distribution.
If Docker is being used this is the name of the Container OS
- Kernel version: the long name of the Linux kernel from /proc/version
If Docker is being used this is the description of the Host OS.
- Clock: the type of clock used
http://gerrit.cloudera.org:8080/#/c/14531/3//COMMIT_MSG@15
PS3, Line 15: OS version: "Ubuntu 16.04.6 LTS"
Why does OS Version have quotes but Kernel version does not?
http://gerrit.cloudera.org:8080/#/c/14531/3/be/src/util/CMakeLists.txt
File be/src/util/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/14531/3/be/src/util/CMakeLists.txt@124
PS3, Line 124: os-info-test.cc
These should be in alphabetical order
http://gerrit.cloudera.org:8080/#/c/14531/3/be/src/util/CMakeLists.txt@187
PS3, Line 187: ADD_UNIFIED_BE_LSAN_TEST(os-info-test "OsInfo.*")
These should be in alphabetical order
http://gerrit.cloudera.org:8080/#/c/14531/3/be/src/util/os-info-test.cc
File be/src/util/os-info-test.cc:
http://gerrit.cloudera.org:8080/#/c/14531/3/be/src/util/os-info-test.cc@25
PS3, Line 25: ASSERT_NE(osinfo.os_version(), "Unknown");
Add a simple comment explaining the test
http://gerrit.cloudera.org:8080/#/c/14531/3/be/src/util/os-info.h
File be/src/util/os-info.h:
http://gerrit.cloudera.org:8080/#/c/14531/3/be/src/util/os-info.h@35
PS3, Line 35: /// Name of the OS release.
Simple name of the OS.
If Docker is used this is the name of the Container OS
http://gerrit.cloudera.org:8080/#/c/14531/3/be/src/util/os-info.h@42
PS3, Line 42: /// and the version of a GCC compiler used to build it.
The version of Linux kernel and the version of the compiler used to build it.
If Docker is used this is the Host OS.
http://gerrit.cloudera.org:8080/#/c/14531/3/be/src/util/os-info.cc
File be/src/util/os-info.cc:
http://gerrit.cloudera.org:8080/#/c/14531/3/be/src/util/os-info.cc@62
PS3, Line 62: os_path = "/etc/centos-release";
Add a comment saying "Only old distributions like Centos 6"
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 00:06:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
......................................................................
IMPALA-8065: Add OS distribution name in OSInfo
Before this change OsInfo::DebugString() would print two lines:
- OS version: the long name of the Linux kernel from /proc/version
- Clock: the type of clock used
After this change OsInfo::DebugString() will print three lines:
- OS distribution: the short name of the OS release.
If Docker is being used this is the name of the Container OS.
- OS version: the long name of the Linux kernel from /proc/version.
If Docker is being used this is the description of the Host Kernel.
- Clock: the type of clock used.
Tested locally, the displayed OS Info in Ubuntu16 dev box is:
OS distribution: Ubuntu 16.04.6 LTS
OS version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC
Also checked with diff OS in docker: centos, redhat, ubuntu, oracle,
debian to make sure /etc/os-release exists and PRETTY_NAME in that file.
Each OS picked one version to test.
Specially for centos6 and redhat6, which have redhat-release instead of
os-release, copied redhat-release into Ubuntu16 dev box and verified os
version in mini-cluster.
Added new backend test os-info-test.cc.
Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
---
M be/src/util/CMakeLists.txt
A be/src/util/os-info-test.cc
M be/src/util/os-info.cc
M be/src/util/os-info.h
4 files changed, 82 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/9
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14531/6/be/src/util/os-info.cc
File be/src/util/os-info.cc:
http://gerrit.cloudera.org:8080/#/c/14531/6/be/src/util/os-info.cc@72
PS6, Line 72: if (fields[0].compare("PRETTY_NAME") == 0) {
> Will this work on Centos6?
Sorry, no, I'll update with fix.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 23:36:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
......................................................................
Patch Set 9:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5113/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 04:04:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Add OS version and Kernel version in OSInfo
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Add OS version and Kernel version in OSInfo
......................................................................
IMPALA-8065 Add OS version and Kernel version in OSInfo
Original we get /proc/version displayed as OS version, while it's
actually kernel version. We should correct it as Kernel version,
and display OS version from /etc/os-release (for centos6 it's
/etc/centos-release).
Tested locally, the displayed OS Info in Ubuntu16 dev box is:
OS version: "Ubuntu 16.04.6 LTS"
Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC
Also tested with diff OS in docker: centos, redhat, ubuntu, oracle,
debian. Each OS picked one version to test.
Added new backend test os-info-test.cc.
Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
---
M be/src/util/CMakeLists.txt
A be/src/util/os-info-test.cc
M be/src/util/os-info.cc
M be/src/util/os-info.h
4 files changed, 71 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/3
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container
......................................................................
Patch Set 1:
(2 comments)
A couple of quick notes
http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc
File be/src/util/os-info.cc:
http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc@56
PS1, Line 56: ifstream os_version("/etc/os-release", ios::in);
I think this file is not present on Centos6.
I *think* we still support that, though I am not 100% sure.
http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc@99
PS1, Line 99: << "Kernel version: " << kernel_version_ << endl
If I were reading this I would be confused: what is OS version, what is Kernel version? Are they the same?
If I am not in Docker what do I see?
My suggestion: only if we are running in Docker print
"Container OS: XXXX"
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Oct 2019 01:00:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
......................................................................
IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Before this change OsInfo::DebugString() would print two lines:
- OS version: the long name of the Linux kernel from /proc/version
- Clock: the type of clock used
After this change OsInfo::DebugString() will print three lines:
- OS version: the short name of the OS release.
If Docker is being used this is the name of the Container OS
- Kernel version: the long name of the Linux kernel from /proc/version.
If Docker is being used this is the description of the Host Kernel.
- Clock: the type of clock used.
Tested locally, the displayed OS Info in Ubuntu16 dev box is:
OS version: Ubuntu 16.04.6 LTS
Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC
Also tested with diff OS in docker: centos, redhat, ubuntu, oracle,
debian. Each OS picked one version to test.
Added new backend test os-info-test.cc.
Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
---
M be/src/util/CMakeLists.txt
A be/src/util/os-info-test.cc
M be/src/util/os-info.cc
M be/src/util/os-info.h
4 files changed, 75 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/7
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 19:39:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
......................................................................
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5289/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 18:54:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4901/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Oct 2019 22:32:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4933/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Nov 2019 00:20:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4920/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Oct 2019 19:11:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo
......................................................................
Patch Set 8:
The code all seems OK. I am still not happy with the names of the fields.
I think it is an unnecessary risk to change the meaning of "OS version:" and it should continue to be the long name of the Linux kernel from /proc/version.
For the short name then we need a new name, what about "OS Release" or "OS Distribution" ?
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 23:33:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 18:54:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container
......................................................................
Patch Set 2:
(7 comments)
Looks like this is getting close.
http://gerrit.cloudera.org:8080/#/c/14531/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14531/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-8065 OSInfo produces somewhat misleading output when running in container
Sometimes it is better to have the first line be not the bug description but a oneline summary of the change.
http://gerrit.cloudera.org:8080/#/c/14531/2//COMMIT_MSG@9
PS2, Line 9: Original we get /proc/version dispalyed as OS version, while it's
Nit: displayed
http://gerrit.cloudera.org:8080/#/c/14531/2//COMMIT_MSG@14
PS2, Line 14: Tested locally, the displayed OS Info in localhost:25020 is:
"in localhost:25020" is confusing, maybe say on a Ubuntu 16 dev box?
http://gerrit.cloudera.org:8080/#/c/14531/2//COMMIT_MSG@21
PS2, Line 21: debian. Each OS picked one version to test.
Can you add a unit test where you check that os version and kernel version are not equal to "Unknown", then you will know this works on all tested platforms, and that it does not break on future platforms.
http://gerrit.cloudera.org:8080/#/c/14531/2/be/src/util/os-info.h
File be/src/util/os-info.h:
http://gerrit.cloudera.org:8080/#/c/14531/2/be/src/util/os-info.h@35
PS2, Line 35: static const std::string os_version() {
Add a description of what this is
http://gerrit.cloudera.org:8080/#/c/14531/2/be/src/util/os-info.h@40
PS2, Line 40: static const std::string kernel_version() {
Add a description of what this is
http://gerrit.cloudera.org:8080/#/c/14531/2/be/src/util/os-info.cc
File be/src/util/os-info.cc:
http://gerrit.cloudera.org:8080/#/c/14531/2/be/src/util/os-info.cc@58
PS2, Line 58: string os_path_ = "Unknown";
local variables should not have the "_" suffux
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Oct 2019 23:25:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
......................................................................
Patch Set 11: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Nov 2019 00:16:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
......................................................................
IMPALA-8065 Edit OS version and Kernel version in OSInfo
Before this change OsInfo::DebugString() would print two lines:
- OS version: the long name of the Linux kernel from /proc/version
- Clock: the type of clock used
After this change OsInfo::DebugString() will print three lines:
- OS version: the short name of the OS release.
If Docker is being used this is the name of the Container OS
- Kernel version: the long name of the Linux kernel from /proc/version.
If Docker is being used this is the description of the Host Kernel.
- Clock: the type of clock used.
Tested locally, the displayed OS Info in Ubuntu16 dev box is:
OS version: Ubuntu 16.04.6 LTS
Kernel version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017)
(gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10))
Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC
Also tested with diff OS in docker: centos, redhat, ubuntu, oracle,
debian. Each OS picked one version to test.
Added new backend test os-info-test.cc.
Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
---
M be/src/util/CMakeLists.txt
A be/src/util/os-info-test.cc
M be/src/util/os-info.cc
M be/src/util/os-info.h
4 files changed, 77 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14531/6
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
......................................................................
Patch Set 10:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5283/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 19:39:47 +0000
Gerrit-HasComments: No