You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2009/07/17 01:24:21 UTC
svn commit: r794905 - in /hadoop/hbase/trunk: CHANGES.txt
src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Author: stack
Date: Thu Jul 16 23:24:21 2009
New Revision: 794905
URL: http://svn.apache.org/viewvc?rev=794905&view=rev
Log:
HBASE-1583 Start/Stop of large cluster untenable
Modified:
hadoop/hbase/trunk/CHANGES.txt
hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Modified: hadoop/hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=794905&r1=794904&r2=794905&view=diff
==============================================================================
--- hadoop/hbase/trunk/CHANGES.txt (original)
+++ hadoop/hbase/trunk/CHANGES.txt Thu Jul 16 23:24:21 2009
@@ -272,6 +272,7 @@
time we cycle the hstore.getStorefilesCount() >
this.blockingStoreFilesNumber loop
HBASE-1058 Disable 1058 on catalog tables
+ HBASE-1583 Start/Stop of large cluster untenable
IMPROVEMENTS
HBASE-1089 Add count of regions on filesystem to master UI; add percentage
Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java?rev=794905&r1=794904&r2=794905&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java Thu Jul 16 23:24:21 2009
@@ -26,17 +26,16 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReentrantLock;
-import org.apache.hadoop.util.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.apache.hadoop.hbase.client.HTable;
-import org.apache.hadoop.hbase.client.Put;
import org.apache.hadoop.hbase.HBaseConfiguration;
-import org.apache.hadoop.hbase.RemoteExceptionHandler;
-import org.apache.hadoop.hbase.HRegionInfo;
import org.apache.hadoop.hbase.HConstants;
-import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.HRegionInfo;
+import org.apache.hadoop.hbase.RemoteExceptionHandler;
+import org.apache.hadoop.hbase.client.HTable;
+import org.apache.hadoop.hbase.client.Put;
import org.apache.hadoop.hbase.util.Writables;
+import org.apache.hadoop.util.StringUtils;
/**
* Compact region on request and then run split if appropriate
Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java?rev=794905&r1=794904&r2=794905&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java Thu Jul 16 23:24:21 2009
@@ -343,6 +343,20 @@
" available; sequence id is " + this.minSequenceId);
}
+ /**
+ * @return True if this region has references.
+ */
+ boolean hasReferences() {
+ for (Map.Entry<byte [], Store> e: this.stores.entrySet()) {
+ for (Map.Entry<Long, StoreFile> ee:
+ e.getValue().getStorefiles().entrySet()) {
+ // Found a reference, return.
+ if (ee.getValue().isReference()) return true;
+ }
+ }
+ return false;
+ }
+
/*
* Write out an info file under the region directory. Useful recovering
* mangled regions.
@@ -747,6 +761,10 @@
*/
byte [] compactStores(final boolean majorCompaction)
throws IOException {
+ if (this.closing.get() || this.closed.get()) {
+ LOG.debug("Skipping compaction on " + this + " because closing/closed");
+ return null;
+ }
splitsAndClosesLock.readLock().lock();
try {
byte [] splitRow = null;
@@ -1487,12 +1505,13 @@
private boolean isFlushSize(final long size) {
return size > this.memstoreFlushSize;
}
-
+
// Do any reconstruction needed from the log
protected void doReconstructionLog(Path oldLogFile, long minSeqId, long maxSeqId,
Progressable reporter)
throws UnsupportedEncodingException, IOException {
// Nothing to do (Replaying is done in HStores)
+ // Used by subclasses; e.g. THBase.
}
protected Store instantiateHStore(Path baseDir,
Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java?rev=794905&r1=794904&r2=794905&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Thu Jul 16 23:24:21 2009
@@ -1553,9 +1553,11 @@
if (region == null) {
try {
region = instantiateRegion(regionInfo);
- // Startup a compaction early if one is needed.
- this.compactSplitThread.
- compactionRequested(region, "Region open check");
+ // Startup a compaction early if one is needed, if region has references.
+ if (region.hasReferences()) {
+ this.compactSplitThread.compactionRequested(region,
+ "Region has references on open");
+ }
} catch (Throwable e) {
Throwable t = cleanup(e,
"Error opening " + regionInfo.getRegionNameAsString());