[jira] [Commented] (FLINK-984) Distinct operator for POJO DataSets without KeySelector and on UnsortedGrouping

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229563#comment-14229563 ] 

ASF GitHub Bot commented on FLINK-984:
--------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/245#issuecomment-65036841
  
    Looks good, +1 to merge!


> Distinct operator for POJO DataSets without KeySelector and on UnsortedGrouping
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-984
>                 URL: https://issues.apache.org/jira/browse/FLINK-984
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ufuk Celebi
>            Assignee: Robert Metzger
>            Priority: Minor
>
> Two issues regarding the distinct operator:
> - The distinct operator does not support {{distinct()}} with POJO datasets. I think it should be possible to implement a reflection based KeySelector which selects all public fields as key?
> - All other grouped operators work by {{groupBy(GROUPING).operator(...)}} whereas the distinct operator does {{distinct(GROUPING)}}. I think it would be more consistent to allow {{groupBy(GROUPING).distinct()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)