You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/25 03:40:08 UTC

[GitHub] [superset] rusackas commented on a change in pull request #13299: test: Adds tests to TableLoader component

rusackas commented on a change in pull request #13299:
URL: https://github.com/apache/superset/pull/13299#discussion_r582506097



##########
File path: superset-frontend/src/components/TableLoader/index.tsx
##########
@@ -17,25 +17,14 @@
  * under the License.
  */
 import React, { useState, useEffect, useMemo } from 'react';
-import PropTypes from 'prop-types';
 import { t, SupersetClient, JsonObject } from '@superset-ui/core';
 import TableView from 'src/components/TableView';
-import withToasts from '../messageToasts/enhancers/withToasts';
-import Loading from './Loading';
-import '../../stylesheets/reactable-pagination.less';
-import { EmptyWrapperType } from './TableView/TableView';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+import Loading from '../Loading';

Review comment:
       ```suggestion
   import Loading from 'src/components/Loading';
   ```
   If we move components around in the future, these consistent src paths should make things less painful.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org