You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/03/03 13:28:31 UTC
Review Request 57286: Popup "Save changed" appears when user switches
config versions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57286/
-----------------------------------------------------------
Review request for Ambari and Denys Buzhor.
Bugs: ambari-20297
https://issues.apache.org/jira/browse/ambari-20297
Repository: ambari
Description
-------
* Create several config versions
* Switch to one of them
* While it's loading (spinner is shown) try to switch to another version
*ER* Confirmation popup should not be shown
*AR* This popup is shown
Diffs
-----
ambari-web/app/views/common/configs/config_history_flow.js 0cd6b7f
Diff: https://reviews.apache.org/r/57286/diff/1/
Testing
-------
30365 passing (22s)
157 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 57286: Popup "Save changed" appears when user
switches config versions
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57286/#review167816
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On March 3, 2017, 1:28 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57286/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 1:28 p.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-20297
> https://issues.apache.org/jira/browse/ambari-20297
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Create several config versions
> * Switch to one of them
> * While it's loading (spinner is shown) try to switch to another version
>
> *ER* Confirmation popup should not be shown
> *AR* This popup is shown
>
>
> Diffs
> -----
>
> ambari-web/app/views/common/configs/config_history_flow.js 0cd6b7f
>
>
> Diff: https://reviews.apache.org/r/57286/diff/1/
>
>
> Testing
> -------
>
> 30365 passing (22s)
> 157 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>