You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "msokolov (via GitHub)" <gi...@apache.org> on 2024/08/10 17:27:51 UTC

[PR] Two fixes for recently-added HnswGraphBuilder.connectComponents: [lucene]

msokolov opened a new pull request, #13642:
URL: https://github.com/apache/lucene/pull/13642

   1. properly set frozen flag to avoid re-duplicative work
   2. don't try to join a node to itself


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Two fixes for recently-added HnswGraphBuilder.connectComponents: [lucene]

Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov commented on PR #13642:
URL: https://github.com/apache/lucene/pull/13642#issuecomment-2282219044

   addresses #13640 
   
   with this fix the failing test seed on that issue succeeded. I re-ran the test with tests.iters=1000 and didn't get any fails


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] Two fixes for recently-added HnswGraphBuilder.connectComponents: [lucene]

Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov merged PR #13642:
URL: https://github.com/apache/lucene/pull/13642


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org