You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/11/03 08:20:38 UTC

[GitHub] [jackrabbit-filevault] kwin commented on pull request #175: JCRVLT-557 - make default for overwriting node types configurable (OSGi)

kwin commented on pull request #175:
URL: https://github.com/apache/jackrabbit-filevault/pull/175#issuecomment-958734498


   > 1. Is it ok that I _removed_ (not deprecated) " public FSPackageRegistry(@NotNull File homeDir, InstallationScope scope, @nullable AbstractPackageRegistry.SecurityConfig securityConfig, boolean isStrict)"
   
   Yes, that is an impl class and should not be used anywhere outside FileVault (although this is only enforced with OSGi)
   
   > 2. Is there work left to do in "PackageTaskOptionsSerializer"?
   Good point, although only used in https://github.com/apache/sling-org-apache-sling-feature-extension-content/blob/7f982174eb877a3a0c7bd6b69862a3a11e9db137/src/main/java/org/apache/sling/feature/extension/content/ContentHandler.java#L82 AFAIK it would be good to serialize all options. We should have some more test coverage for this class as well.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org