You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "wolfboys (via GitHub)" <gi...@apache.org> on 2023/06/14 06:46:40 UTC
[GitHub] [incubator-streampark] wolfboys opened a new pull request, #2798: yarn resourceManager URL bug fix
wolfboys opened a new pull request, #2798:
URL: https://github.com/apache/incubator-streampark/pull/2798
yarn resourceManager URL bug fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] macksonmu merged pull request #2798: yarn resourceManager URL bug fix
Posted by "macksonmu (via GitHub)" <gi...@apache.org>.
macksonmu merged PR #2798:
URL: https://github.com/apache/incubator-streampark/pull/2798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhoulii commented on a diff in pull request #2798: yarn resourceManager URL bug fix
Posted by "zhoulii (via GitHub)" <gi...@apache.org>.
zhoulii commented on code in PR #2798:
URL: https://github.com/apache/incubator-streampark/pull/2798#discussion_r1231745768
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/bean/AlertTemplate.java:
##########
@@ -60,7 +60,7 @@ private static AlertTemplate of(Application application) {
if (ExecutionMode.isYarnMode(application.getExecutionMode())) {
String format = "%s/proxy/%s/";
- String url = String.format(format, YarnUtils.getRMWebAppURL(), application.getAppId());
+ String url = String.format(format, YarnUtils.getRMWebAppURL(false), application.getAppId());
Review Comment:
do we have to get dynamic url here ? if not, we can omit the false parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2798: yarn resourceManager URL bug fix
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2798:
URL: https://github.com/apache/incubator-streampark/pull/2798#issuecomment-1593889094
cc @macksonmu @zhoulii PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2798: yarn resourceManager URL bug fix
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #2798:
URL: https://github.com/apache/incubator-streampark/pull/2798#discussion_r1232921473
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/bean/AlertTemplate.java:
##########
@@ -60,7 +60,7 @@ private static AlertTemplate of(Application application) {
if (ExecutionMode.isYarnMode(application.getExecutionMode())) {
String format = "%s/proxy/%s/";
- String url = String.format(format, YarnUtils.getRMWebAppURL(), application.getAppId());
+ String url = String.format(format, YarnUtils.getRMWebAppURL(false), application.getAppId());
Review Comment:
> do we have to get dynamic url here ? if not, we can omit the false parameter.
If the latest YARN RM url is obtained every time, it will result in more network requests and resource consumption. Obtaining a currently valid active rm url requires a lot of work, as you can see in `org.apache.hadoop.yarn.util.RMHAUtils.findActiveRMHAId` and [streampark](https://github.com/apache/incubator-streampark/blob/827fe32449a25d05a73999a59727f782529e69ff/streampark-common/src/main/scala/org/apache/streampark/common/util/YarnUtils.scala#L159.), by default, we return the previously active rm url. If this url is not available, we will retrieve the latest active node again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org