[jira] Commented: (OFBIZ-1880) Using screenlets in Catalog Manager Application

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614383#action_12614383 ] 

Jacques Le Roux commented on OFBIZ-1880:
----------------------------------------

Hi Bruno,

I just reviewed and tested your patch. It's ok but some minor things.

1. Please when you remove a file, don't empty it, really remove it. Actually this is not a problem using a tool like Tortoise, but it's a better way of doing it at large. For instance you are deleting 2 times webapp/catalog/includes/appheader.ftl in your patch :o)
2. I was ready to commit your file, but I think your forgot to put in the controller. For 2 reasons : I can't see a duplicated viewmap entry removed, and the link to FIndProduct you added here
    +        <menu-item name="main" title="${uiLabelMap.ProductMain}"><link target="main"/></menu-item>
    +        <menu-item name="products" title="${uiLabelMap.Products}"><link target="FindProduct"/></menu-item>
    +        <menu-item name="featurecats" title="${uiLabelMap.ProductFeatureCats}"><link target="EditFeatureCategories"/></menu-item>
does not exist.

As soon as you will update the patch I will commit thanks

Thanks for you good work !




> Using screenlets in Catalog Manager Application
> -----------------------------------------------
>
>                 Key: OFBIZ-1880
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1880
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: ScreenletCatalog.patch
>
>
> Please find attached a patch to use the screenlet widget in the Catalog Manager Application.
> - The leftbar is now using the screenlet widget, all the collapsable stuff in the .FTL files has been removed using the screenlet widget provided collapse functionality.
> - The appheader.ftl file has been removed and the menu in now implemented with menu widgets in a standard Menus.xml file
> - The CatalogCommonScreens.xml file has been merged into the more standard CommonScreens.xml file
> - A duplicated viewmap entry in the controller has been removed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.