You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "guptanikhil007 (via GitHub)" <gi...@apache.org> on 2023/04/03 06:23:06 UTC
[GitHub] [hive] guptanikhil007 opened a new pull request, #4193: HIVE-27209: Backport HIVE-24569 to branch-3: : LLAP daemon leaks file descriptors/log4j appenders
guptanikhil007 opened a new pull request, #4193:
URL: https://github.com/apache/hive/pull/4193
HIVE-24569: LLAP daemon leaks file descriptors/log4j appenders
Author: (Stamatis Zampetakis, reviewed by Jesus Camacho Rodriguez)
Closes apache/hive#1952
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Based on ee4e1f3c3bdf8e644143f8039cbda55d97710461
But modified to exclude tests that require JUnit5 and minor changes in the constructor of
LLapRandomAccessFileAppender to account for the differences in the versions log4j.version.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This Backport was already done in branch-3.1 using this [HIVE-24569](https://issues.apache.org/jira/browse/HIVE-24569) so we need to backport the same to branch-3.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] guptanikhil007 commented on pull request #4193: HIVE-27209: Backport HIVE-24569 to branch-3: LLAP daemon leaks file descriptors/log4j appenders
Posted by "guptanikhil007 (via GitHub)" <gi...@apache.org>.
guptanikhil007 commented on PR #4193:
URL: https://github.com/apache/hive/pull/4193#issuecomment-1502851888
https://github.com/apache/hive/pull/1952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] guptanikhil007 commented on pull request #4193: HIVE-27209: Backport HIVE-24569 to branch-3: : LLAP daemon leaks file descriptors/log4j appenders
Posted by "guptanikhil007 (via GitHub)" <gi...@apache.org>.
guptanikhil007 commented on PR #4193:
URL: https://github.com/apache/hive/pull/4193#issuecomment-1493795899
@vihangk1 and @sankarh Can you review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sankarh commented on pull request #4193: HIVE-27209: Backport HIVE-24569 to branch-3: LLAP daemon leaks file descriptors/log4j appenders
Posted by "sankarh (via GitHub)" <gi...@apache.org>.
sankarh commented on PR #4193:
URL: https://github.com/apache/hive/pull/4193#issuecomment-1501373334
@guptanikhil007 Why test changes are not ported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] guptanikhil007 commented on pull request #4193: HIVE-27209: Backport HIVE-24569 to branch-3: LLAP daemon leaks file descriptors/log4j appenders
Posted by "guptanikhil007 (via GitHub)" <gi...@apache.org>.
guptanikhil007 commented on PR #4193:
URL: https://github.com/apache/hive/pull/4193#issuecomment-1501431789
@sankarh This is ported from the original branch-3.1 cherry-pick not master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] TuroczyX commented on pull request #4193: HIVE-27209: Backport HIVE-24569 to branch-3: : LLAP daemon leaks file descriptors/log4j appenders
Posted by "TuroczyX (via GitHub)" <gi...@apache.org>.
TuroczyX commented on PR #4193:
URL: https://github.com/apache/hive/pull/4193#issuecomment-1494360123
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4193: HIVE-27209: Backport HIVE-24569 to branch-3: : LLAP daemon leaks file descriptors/log4j appenders
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4193:
URL: https://github.com/apache/hive/pull/4193#issuecomment-1493745635
+1 LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sankarh merged pull request #4193: HIVE-27209: Backport HIVE-24569 to branch-3: LLAP daemon leaks file descriptors/log4j appenders
Posted by "sankarh (via GitHub)" <gi...@apache.org>.
sankarh merged PR #4193:
URL: https://github.com/apache/hive/pull/4193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org