You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/05/17 19:28:57 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request, #6841: Add more t3c profile layering

rob05c opened a new pull request, #6841:
URL: https://github.com/apache/trafficcontrol/pull/6841

   Fixes more places of t3c and lib/go-atscfg to layer profiles
   
   I think this is the last of the t3c profile layering stuff. Halfway between bug and feature. Part of a new feature, but will be a bug if it isn't added before users can assign multiple profiles.
   
   Draft: needs tests.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Control Cache Config (`t3c`, formerly ORT)
   
   ## What is the best way to verify this PR?
   Run tests. Run t3c, verify behavior is still correct for single profile. Can't currently assign multiple profiles in TO, but you could hypothetically manually test multiple by running t3c-request, saving the output, manually editing it to have multiple profiles, then passing that to t3c-generate.
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   Not a bug fix / not in a release.
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - ~[x] This PR has documentation~ no docs, layered profiles docs already exist, and t3c behavior doesn't do anything special <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - ~[x] This PR has a CHANGELOG.md entry~ no changelog, changelog for layered profiles already exists <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] zrhoffman merged pull request #6841: Add more t3c profile layering

Posted by GitBox <gi...@apache.org>.
zrhoffman merged PR #6841:
URL: https://github.com/apache/trafficcontrol/pull/6841


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org