You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/25 21:05:44 UTC

[GitHub] [geode] Bill commented on a change in pull request #5306: GEODE-8195: ConcurrentModificationException from LocatorMembershipLis…

Bill commented on a change in pull request #5306:
URL: https://github.com/apache/geode/pull/5306#discussion_r445836429



##########
File path: geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java
##########
@@ -328,6 +331,7 @@ public void run() {
                   Thread.currentThread().interrupt();
                   logger.warn(
                       "Locator Membership listener permanently failed to exchange locator information due to interruption.");
+                  return;

Review comment:
       If a sleep is interrupted we now bail out of `run()` entirely, rather than continuing on to attempt delivering the message to the next target. Why the change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org