[GitHub] timifasubaa commented on a change in pull request #5567: make filters use security manager

[GitBox <gi...@apache.org>]

timifasubaa commented on a change in pull request #5567: make filters use security manager
URL: https://github.com/apache/incubator-superset/pull/5567#discussion_r210448624
 
 

 ##########
 File path: superset/views/base.py
 ##########
 @@ -248,15 +248,11 @@ def get_view_menus(self, permission_name):
                 vm.add(vm_name)
         return vm
 
-    def has_all_datasource_access(self):
-        return (
-            self.has_role(['Admin', 'Alpha']) or
 
 Review comment:
   There are only three usage of the has_all_datasource_access and they are the ones I changed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org