[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7641: [SQL Lab] Clarify SQL Lab query and display limits

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #7641: [SQL Lab] Clarify SQL Lab query and display limits
URL: https://github.com/apache/incubator-superset/pull/7641#discussion_r290127337
 
 

 ##########
 File path: superset/models/sql_lab.py
 ##########
 @@ -94,6 +94,8 @@ class Query(Model, ExtraJSONMixin):
         sqla.Index('ti_user_id_changed_on', user_id, changed_on),
     )
 
+    # TODO: Clean up/fix/refactor limit_reached and limit_used. limit_used defaults
 
 Review comment:
   Agreed looks like we can drop both now. I'm guessing they got orphaned with the back and forth around limits

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org