You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@me.com> on 2014/10/10 21:56:27 UTC
output method in installer
HI,
This code in the badly named output method looks wrong to me:
if (currentStep < stepLabels.length && "\n" + stepIDs[currentStep] + ":" == s)
{
if (currentStep > 0)
updateActivityStep(stepLabels[currentStep - 1], StepItem.COMPLETE);
if (currentStep < stepLabels.length)
updateActivityStep(stepLabels[currentStep++], StepItem.ACTIVE);
}
Justin
Re: output method in installer
Posted by Alex Harui <ah...@adobe.com>.
On 10/10/14, 1:17 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>Just something I noticed while fixing something else - looks a little
>broken to me.
IIRC, there might be an issue with errors before the first Ant step. Is
that what you saw? Feel free to make changes there, but I think it works
mostly when the steps are being executed by ant_on_air.
-Alex
Re: output method in installer
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Just something I noticed while fixing something else - looks a little broken to me.
Justin
Re: output method in installer
Posted by Erik de Bruin <er...@ixsoftware.nl>.
A challenge, or did you just want to share while you were committing a fix?
EdB
On Friday, October 10, 2014, Justin Mclean <ju...@me.com> wrote:
> HI,
>
> This code in the badly named output method looks wrong to me:
>
> if (currentStep < stepLabels.length && "\n" +
> stepIDs[currentStep] + ":" == s)
> {
> if (currentStep > 0)
> updateActivityStep(stepLabels[currentStep - 1],
> StepItem.COMPLETE);
> if (currentStep < stepLabels.length)
> updateActivityStep(stepLabels[currentStep++],
> StepItem.ACTIVE);
> }
>
> Justin
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl